Do not take constructive implication into account in InfoStringOfInstalledOperationsOfCategory #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alledOperationsOfCategory Since some time, InfoStringOfInstalledOperationsOfCategory lists all mathematical properties, not only constructive ones. Filtering by constructive implication is unexpected in this setup.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1362 +/- ##
=======================================
Coverage 79.51% 79.51%
=======================================
Files 500 500
Lines 62482 62482
=======================================
Hits 49682 49682
Misses 12800 12800
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mohamed-barakat
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since some time, InfoStringOfInstalledOperationsOfCategory lists all mathematical properties, not only constructive ones. Filtering by constructive implication is unexpected in this setup.
Fixes #1360.