Fix pyarrow and dask parquet issues #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI passing on github actions on ubuntu using Python 3.8. Expanding test matrix to cover Python 3.7 to 3.10 and all 3 major platforms. |
This was referenced Jul 27, 2022
maximlt
reviewed
Jul 27, 2022
| PKG_TEST_PYTHON: "--test-python=py37" | ||
| PYTHON_VERSION: "3.7" | ||
| PKG_TEST_PYTHON: "--test-python=py39" | ||
| PYTHON_VERSION: "3.9" |
There was a problem hiding this comment.
There's a known issue on pyctdev that occurs when building a package with a base Python version greater than 3.7. You might hit that :/
There was a problem hiding this comment.
Thanks, I will revert to 3.7 for the time being then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final set of fixes identified in issue #86. CI works locally for me now.
The changes are all related to API changes and deprecations in pyarrow between 5.0.0 and 8.0.0. Changes were required in our code to directly deal with these as well as other changes following dask modifications to deal with the same.
I have created a new script
_create_testdata.pyto create test parquet files that are stored in the newtests/test_datadirectory and these are checked as part ofpytest. The last time the CI definitely worked was July 2021 withpyarrow==5.0.0anddask==2021.7.2(and the same fordistributed). These files are successfully read with up-to-datepyarrow==8.0.0anddask==2022.7.1. Similarly, test parquet files create with the up-to-datepyarrowanddaskare successfully read withpyarrow==5.0.0anddask==2021.7.2.