-
-
Notifications
You must be signed in to change notification settings - Fork 569
Allow Tabulator.row_content to be an awaitable #8309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| placeholder.object = resolved | ||
| placeholder.loading = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| placeholder.object = resolved | |
| placeholder.loading = False | |
| placeholder.param.update(object=resolved, loading=False) |
| return child.children[0].text | ||
|
|
||
|
|
||
| def test_tabulator_expanded_content_async(document, comm): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think you have to make these tests async as well
| def test_tabulator_expanded_content_async(document, comm): | |
| async def test_tabulator_expanded_content_async(document, comm): |
| assert len(model.children) == 1 | ||
|
|
||
|
|
||
| def test_tabulator_content_embed_async(document, comm): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| def test_tabulator_content_embed_async(document, comm): | |
| async def test_tabulator_content_embed_async(document, comm): |
This PR allows
row_contentto be an awaitable. When it is an awaitable, we display first a small spacer with a loading spinner, replaced by the content returned by the function.Micro app to play around with this feature:
Draft as I'd like to test it in an app with a more complex
row_contentfunction.