Ensure that autoreload records modules to watch before startup #7399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7399 +/- ##
==========================================
- Coverage 82.22% 82.22% -0.01%
==========================================
Files 337 337
Lines 50514 50534 +20
==========================================
+ Hits 41537 41552 +15
- Misses 8977 8982 +5 ☔ View full report in Codecov by Sentry. |
philippjfr
commented
Oct 14, 2024
philippjfr
commented
Oct 14, 2024
hoxbro
approved these changes
Oct 14, 2024
ahuang11
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Ensure that autoreload records modules to watch before startup * Apply suggestions from code review * Apply suggestions from code review * Add test * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression that meant that the
--autoreload/--devoptions did not correctly record the modules that would have to be reloaded.Fixes #7398, Fixes #7396