Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reset Tabulator selection if there was no selection #6968

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

philippjfr
Copy link
Member

Ensures we do not send a selection reset event if not required.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.69%. Comparing base (d273e5a) to head (e168b63).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6968      +/-   ##
==========================================
- Coverage   81.71%   81.69%   -0.02%     
==========================================
  Files         326      326              
  Lines       48031    48031              
==========================================
- Hits        39248    39240       -8     
- Misses       8783     8791       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit c8262cb into main Jul 11, 2024
15 checks passed
@philippjfr philippjfr deleted the tables_reset_selection_fix branch July 11, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant