Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: rasterio 1.4.2 #763

Merged
merged 3 commits into from
Nov 10, 2024
Merged

compat: rasterio 1.4.2 #763

merged 3 commits into from
Nov 10, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 1, 2024

@hoxbro hoxbro marked this pull request as draft November 1, 2024 16:32
@hoxbro
Copy link
Member Author

hoxbro commented Nov 4, 2024

This seems to be the difference:

import rioxarray as rxr

file = "https://github.com/holoviz/hvplot/raw/main/hvplot/tests/data/RGB-red.byte.tif"
data = rxr.open_rasterio(file)
data.rio.crs
# rasterio 1.4.1:  CRS.from_epsg(32618)
# rasterio 1.4.2:  CRS.from_wkt('PROJCS["WGS 84 / UTM zone 18N",GEOGCS["WGS 84",DATUM["WGS_1984",SPHEROID["WGS 84",6378137,298.257223563,AUTHORITY["EPSG","7030"]],AUTHORITY["EPSG","6326"]],PRIMEM["Greenwich",0,AUTHORITY["EPSG","8901"]],UNIT["degree",0.0174532925199433,AUTHORITY["EPSG","9122"]],AUTHORITY["EPSG","4326"]],PROJECTION["Transverse_Mercator"],PARAMETER["latitude_of_origin",0],PARAMETER["central_meridian",-75],PARAMETER["scale_factor",0.9996],PARAMETER["false_easting",500000],PARAMETER["false_northing",0],UNIT["metre",1,AUTHORITY["EPSG","9001"]],AXIS["Easting",EAST],AXIS["Northing",NORTH],AUTHORITY["EPSG","32618"]]')
data.rio.crs.to_proj4()
# rasterio 1.4.1: +init=epsg:32618
# rasterio 1.4.2: +proj=utm +zone=18 +datum=WGS84 +units=m +no_defs=True

@hoxbro hoxbro changed the title test: Check failing test is related to new rasterio release compat: rasterio 1.4.2 Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.42%. Comparing base (2fbf772) to head (544f000).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
+ Coverage   67.36%   67.42%   +0.05%     
==========================================
  Files          45       45              
  Lines        4667     4672       +5     
==========================================
+ Hits         3144     3150       +6     
+ Misses       1523     1522       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro requested a review from ahuang11 November 4, 2024 08:59
@hoxbro hoxbro marked this pull request as ready for review November 4, 2024 09:00
@hoxbro hoxbro mentioned this pull request Nov 9, 2024
geoviews/util.py Outdated Show resolved Hide resolved
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
@hoxbro hoxbro enabled auto-merge (squash) November 10, 2024 17:55
@hoxbro hoxbro disabled auto-merge November 10, 2024 18:06
@hoxbro hoxbro merged commit 79cde9d into main Nov 10, 2024
5 of 12 checks passed
@hoxbro hoxbro deleted the test_rasterio branch November 10, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants