Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to release 1.13.0.rc1 #739

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Prepare to release 1.13.0.rc1 #739

merged 1 commit into from
Aug 1, 2024

Conversation

ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Aug 1, 2024

No description provided.

@ahuang11 ahuang11 requested a review from hoxbro August 1, 2024 16:32
@hoxbro
Copy link
Member

hoxbro commented Aug 1, 2024

A bit of a chicken and age here, as you need a git tag for the Python version

I, therefore, usually do these pushes directly to the main.

As you are likely aware, an official release does not make much sense until we release Panel 1.5, because of Bokeh 3.5 support.

"lockfileVersion": 2,
"requires": true,
"packages": {
"": {
"name": "@holoviz/geoviews",
"version": "1.12.0",
"version": "1.13.0-rc.1",
"license": "BSD-3-Clause",
"dependencies": {
"@bokeh/bokehjs": "~3.4.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 3.5

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have opened here: #740

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; how did you get the other versions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm update bokeh in the GeoViews folder

@ahuang11
Copy link
Collaborator Author

ahuang11 commented Aug 1, 2024

Right I was planning to make a git tag for the Python version after this was approved + merged, and it was a good thing you picked up on the 3.5 thing. Pushing to main is quite scary for me :D

@ahuang11 ahuang11 enabled auto-merge (squash) August 1, 2024 17:05
@ahuang11
Copy link
Collaborator Author

ahuang11 commented Aug 1, 2024

Ok I'll push this to main directly and release rc

@ahuang11
Copy link
Collaborator Author

ahuang11 commented Aug 1, 2024

Nevermind, I don't have permissions I think

Enumerating objects: 9, done.
Counting objects: 100% (9/9), done.
Delta compression using up to 12 threads
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 471 bytes | 471.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (4/4), completed with 4 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: 7 of 7 required status checks are expected.
To https://github.com/holoviz/geoviews.git
 ! [remote rejected] main -> main (protected branch hook declined)
error: failed to push some refs to 'https://github.com/holoviz/geoviews.git'

@hoxbro
Copy link
Member

hoxbro commented Aug 1, 2024

Then just merge this and try to see if you can tag.

@ahuang11 ahuang11 disabled auto-merge August 1, 2024 17:31
@ahuang11
Copy link
Collaborator Author

ahuang11 commented Aug 1, 2024

Can't merge either. Don't have permissions here.

image

@hoxbro
Copy link
Member

hoxbro commented Aug 1, 2024

What if you click on the small arrow next to the button?

@ahuang11
Copy link
Collaborator Author

ahuang11 commented Aug 1, 2024

Which one? Isn't that already in the screenshot

@ahuang11 ahuang11 enabled auto-merge (squash) August 1, 2024 17:58
@ahuang11 ahuang11 disabled auto-merge August 1, 2024 17:58
@hoxbro
Copy link
Member

hoxbro commented Aug 1, 2024

image

@ahuang11
Copy link
Collaborator Author

ahuang11 commented Aug 1, 2024

Yes those are the options I see; same as the screenshot above

image

@hoxbro hoxbro merged commit 7d1d56d into main Aug 1, 2024
3 of 10 checks passed
@hoxbro hoxbro deleted the release_1130rc1 branch August 1, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants