Update pre-commit and fix test suite

.github/workflows/test.yaml

@@ -5,10 +5,23 @@ on:
       - main
   pull_request:
     branches:
-    - '*'
+      - "*"
   workflow_dispatch:
+    inputs:
+      target:
+        description: "How much of the test suite to run"
+        type: choice
+        default: default
+        options:
+          - default
+          - full
+          - downstream
+      cache:
+        description: "Use cache"
+        type: boolean
+        default: true
   schedule:
-    - cron: '0 18 * * SUN'
+    - cron: "0 18 * * SUN"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
@@ -29,67 +42,124 @@ defaults:
 jobs:
   pre_commit:
     name: Run pre-commit
-    runs-on: 'ubuntu-latest'
+    runs-on: "ubuntu-latest"
     steps:
       - uses: holoviz-dev/holoviz_tasks/pre-commit@v0.1a19
+  setup:
+    name: Setup workflow
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: read
+    outputs:
+      code_change: ${{ steps.filter.outputs.code }}
+      matrix: ${{ env.MATRIX }}
+    steps:
+      - uses: actions/checkout@v3
+        if: github.event_name != 'pull_request'
+      - name: Check for code changes
+        uses: dorny/paths-filter@v3
+        id: filter
+        with:
+          filters: |
+            code:
+              - 'geoviews/**'
+              - 'examples/**'
+              - 'setup.py'
+              - 'pyproject.toml'
+              - '.github/workflows/test.yaml'
+      - name: Set matrix option
+        run: |
+          if [[ '${{ github.event_name }}' == 'workflow_dispatch' ]]; then
+            OPTION=${{ github.event.inputs.target }}
+          elif [[ '${{ github.event_name }}' == 'schedule' ]]; then
+            OPTION="full"
+          elif [[ '${{ github.event_name }}' == 'push' && '${{ github.ref_type }}' == 'tag' ]]; then
+            OPTION="full"
+          else
+            OPTION="default"
+          fi
+          echo "MATRIX_OPTION=$OPTION" >> $GITHUB_ENV
+      - name: Set test matrix with 'default' option
+        if: env.MATRIX_OPTION == 'default'
+        run: |
+          MATRIX=$(jq -nsc '{
+              "os": ["ubuntu-latest", "macos-latest", "windows-latest"],
+              "python-version": ["3.9", "3.11"]
+          }')
+          echo "MATRIX=$MATRIX" >> $GITHUB_ENV
+      - name: Set test matrix with 'full' option
+        if: env.MATRIX_OPTION == 'full'
+        run: |
+          MATRIX=$(jq -nsc '{
+              "os": ["ubuntu-latest", "macos-latest", "windows-latest"],
+              "python-version": ["3.9", "3.10", "3.11"]
+          }')
+          echo "MATRIX=$MATRIX" >> $GITHUB_ENV
+      - name: Set test matrix with 'downstream' option
+        if: env.MATRIX_OPTION == 'downstream'
+        run: |
+          MATRIX=$(jq -nsc '{
+              "os": ["ubuntu-latest"],
+              "python-version": ["3.11"]
+          }')
+          echo "MATRIX=$MATRIX" >> $GITHUB_ENV
+
   unit_test_suite:
     name: Unit tests on Python ${{ matrix.python-version }}, ${{ matrix.os }}
-    needs: [pre_commit]
+    needs: [pre_commit, setup]
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
-      matrix:
-        os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
-        python-version: ["3.9", "3.11"]
-        include:
-          - os: 'ubuntu-latest'
-            python-version: '3.10'
+      matrix: ${{ fromJson(needs.setup.outputs.matrix) }}
     timeout-minutes: 60
     steps:
       - uses: holoviz-dev/holoviz_tasks/install@v0.1a19
+        if: needs.setup.outputs.code_change == 'true'
         with:
           name: unit_test_suite
           python-version: ${{ matrix.python-version }}
           channel-priority: strict
           channels: pyviz/label/dev,bokeh,conda-forge,nodefaults
           envs: "-o tests -o examples_extra -o recommended -o tests_ci"
-          cache: true
+          cache: ${{ github.event.inputs.cache || github.event.inputs.cache == '' }}
           conda-update: true
           nodejs: true
         id: install
       - name: download data
+        if: needs.setup.outputs.code_change == 'true'
         run: |
           conda activate test-environment
           bash scripts/download_data.sh
       - name: git describe
+        if: needs.setup.outputs.code_change == 'true'
         run: |
           git describe
       - name: doit test_unit
+        if: needs.setup.outputs.code_change == 'true'
         run: |
           conda activate test-environment
           doit test_unit
       - name: test examples
+        if: needs.setup.outputs.code_change == 'true'
         run: |
           conda activate test-environment
           doit test_examples
       - name: codecov
-        if: github.event_name == 'push'
+        if: needs.setup.outputs.code_change == 'true'
         run: |
           conda activate test-environment
           codecov
+
   core_test_suite:
     name: Core tests on Python ${{ matrix.python-version }}, ${{ matrix.os }}
     needs: [pre_commit]
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
-        os: ['ubuntu-latest']
-        python-version: ['3.12']
+        os: ["ubuntu-latest"]
+        python-version: ["3.12"]
     timeout-minutes: 120
-    env:
-      DESC: "Python ${{ matrix.python-version }}, ${{ matrix.os }} core tests"
-      PYTHON_VERSION: ${{ matrix.python-version }}
     steps:
       # Add back when this works on Python 3.12
       # - uses: holoviz-dev/holoviz_tasks/install@v0.1a19
@@ -99,7 +169,7 @@ jobs:
       #     # channel-priority: strict
       #     channels: pyviz/label/dev,conda-forge,nodefaults
       #     envs: "-o tests_core -o tests_ci"
-      #     cache: true
+      #     cache: ${{ github.event.inputs.cache || github.event.inputs.cache == '' }}
       #     conda-update: true
       #     id: install
       - uses: actions/checkout@v3
@@ -109,11 +179,12 @@ jobs:
         run: git fetch --prune --tags --unshallow -f
       - uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 20.x
       - uses: actions/setup-python@v4
         with:
           python-version: "3.12"
-      - run: |
+      - name: install
+        run: |
           python -m pip install -ve '.[tests_core, tests_ci]'
       - name: download data
         run: |

.pre-commit-config.yaml

@@ -20,7 +20,7 @@ repos:
       - id: check-json
       - id: detect-private-key
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.2.1
+    rev: v0.3.3
     hooks:
       - id: ruff
         files: geoviews/
@@ -41,6 +41,6 @@ repos:
       - id: rst-directive-colons
       - id: rst-inline-touching-normal
   - repo: https://github.com/shellcheck-py/shellcheck-py
-    rev: v0.9.0.6
+    rev: v0.10.0.1
     hooks:
       - id: shellcheck

geoviews/operation/projection.py

@@ -251,12 +251,14 @@ def _process_element(self, element):
         new_data[mdim.name] = mag[mask]
 
         if len(new_data[xdim.name]) == 0:
-            self.param.warning('While projecting a {} element from a {} coordinate '
-                         'reference system (crs) to a {} projection none of '
-                         'the projected paths were contained within the bounds '
-                         'specified by the projection. Ensure you have specified '
-                         'the correct coordinate system for your data.'.format(type(element).__name__, type(element.crs).__name__,
-                          type(self.p.projection).__name__))
+            self.param.warning(
+                f'While projecting a {type(element).__name__} element from '
+                f'a {type(element.crs).__name__} coordinate reference system (crs) '
+                f'to a {type(self.p.projection).__name__} projection none of '
+                'the projected paths were contained within the bounds '
+                'specified by the projection. Ensure you have specified '
+                'the correct coordinate system for your data.'
+            )
 
         return element.clone(tuple(new_data[d.name] for d in element.dimensions()),
                              crs=self.p.projection, datatype=datatype)

geoviews/tests/__init__.py

@@ -1,6 +0,0 @@
-try:
-    # Standardize backend due to random inconsistencies
-    import matplotlib.pyplot as plt
-    plt.switch_backend('agg')
-except ImportError:
-    pass

geoviews/tests/conftest.py

@@ -0,0 +1,14 @@
+import contextlib
+
+
+with contextlib.suppress(ImportError):
+    import matplotlib.pyplot as plt
+
+    plt.switch_backend("agg")
+
+with contextlib.suppress(Exception):
+    # From Dask 2024.3.0 they now use `dask_expr` by default
+    # https://github.com/dask/dask/issues/10995
+    import dask
+
+    dask.config.set({"dataframe.query-planning": False})

pyproject.toml

@@ -83,4 +83,7 @@ filterwarnings = [
     "ignore:datetime.datetime.utcfromtimestamp():DeprecationWarning:dateutil.tz.tz",  # https://github.com/dateutil/dateutil/pull/1285
     # 2024-02
     "ignore:The current Dask DataFrame implementation is deprecated:DeprecationWarning",  # https://github.com/dask/dask/issues/10917
+    # 2024-03
+    "ignore:\\s*Dask dataframe query planning is disabled because dask-expr is not installed:FutureWarning",
+    "ignore:numpy.ndarray size changed, may indicate binary incompatibility:RuntimeWarning",  # https://github.com/pydata/xarray/issues/7259
 ]

scripts/download_data.sh

@@ -2,10 +2,10 @@
 
 set -euxo pipefail
 
-bokeh sampledata
+python -m bokeh sampledata
 
 HERE=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
-geoviews fetch-data --path="$HERE/../examples"
+python -m geoviews fetch-data --path="$HERE/../examples" || echo "geoviews fetch-data failed"
 
 python -c "
 try: