Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make states fill_color="none" (transparent) #643

Merged
merged 6 commits into from
May 25, 2023
Merged

Make states fill_color="none" (transparent) #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
09eab56
Make states fill_color="none" (transparent)
ahuang11 May 24, 2023
c39e645
Update to None
ahuang11 May 24, 2023
52f41dd
Update CHANGELOG.md
ahuang11 May 24, 2023
cec8509
Update releases.rst
ahuang11 May 24, 2023
8666f0f
spacing
ahuang11 May 24, 2023
2a61b13
Number
ahuang11 May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,13 @@ This release adds Bokeh 3 support to Geoviews, along with bug fixes and enhancem

This release also deprecates the `Wikipedia` tile source. If you are using this tile source, please switch to the `OSM` tile source instead. The `Wikipedia` tile source will be removed in version 1.11.0. `geoviews.util.load_tiff` has also been deprecated `rioxarray.open_rasterio` to load GeoTIFFs into a `xarray.DataArray`.

Note, this release has a minor breaking change where `gv.feature.states` defaults to `fill_color=None` so the fill color is transparent.

Enhancements:

- Add Bokeh 3 support to GeoViews ([#625](https://github.com/holoviz/geoviews/pull/625))
- Add `PandasAPI` to `GeoPandasInterface` ([#620](https://github.com/holoviz/geoviews/pull/620))
- Updated the default for `gv.feature.states` to `fill_color=None` ([#643](https://github.com/holoviz/geoviews/pull/643))

Bug fixes:

Expand Down
7 changes: 6 additions & 1 deletion doc/releases.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Version 1.10.0
Date: May 24, 2023

This release adds Bokeh 3 support to Geoviews, along with bug fixes and
enhancements. Many thanks to @maximlt, @philippjfr, and @Hoxbro.
enhancements. Many thanks to @maximlt, @philippjfr, @Hoxbro, and @ahuang11.

This release also deprecates the ``Wikipedia`` tile source. If you are
using this tile source, please switch to the ``OSM`` tile source
Expand All @@ -16,12 +16,17 @@ instead. The ``Wikipedia`` tile source will be removed in version
``rioxarray.open_rasterio`` to load GeoTIFFs into a
``xarray.DataArray``.

Note, this release has a minor breaking change where `gv.feature.states`
defaults to `fill_color=None` so the fill color is transparent.

Enhancements:

- Add Bokeh 3 support to GeoViews
(`#625 <https://github.com/holoviz/geoviews/pull/625>`__)
- Add ``PandasAPI`` to ``GeoPandasInterface``
(`#620 <https://github.com/holoviz/geoviews/pull/620>`__)
- Updated the default for ``gv.feature.states`` to ``fill_color=None``
(`#643 <https://github.com/holoviz/geoviews/pull/643>`__)

Bug fixes:

Expand Down
1 change: 1 addition & 0 deletions geoviews/plotting/bokeh/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,4 +307,5 @@ def _process(self, element, key=None):
options.Feature.Lakes = Options('style', fill_color='#97b6e1', line_color='#97b6e1')
options.Feature.Rivers = Options('style', line_color='#97b6e1')
options.Feature.Grid = Options('style', line_width=0.5, alpha=0.5, line_color='gray')
options.Feature.States = Options('style', fill_color=None)
options.Shape = Options('style', line_color='black', fill_color='#30A2DA')