Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port custom tools, streams and links from EarthSim #377

Merged
merged 12 commits into from
Jan 4, 2020

Conversation

philippjfr
Copy link
Member

No description provided.

@philippjfr philippjfr force-pushed the philippjfr/custom_tools branch 3 times, most recently from 5101830 to cedcb69 Compare November 4, 2019 16:19
@jbednar
Copy link
Member

jbednar commented Nov 4, 2019

Presumably these will need some user guide notebooks? I also don't see what makes them geoviews specific (as opposed to HoloViews) on a quick glance.

@philippjfr
Copy link
Member Author

I also don't see what makes them geoviews specific (as opposed to HoloViews) on a quick glance.

I realize this discussion happened a while ago but we discussed the plan that these would move to GeoViews for the time being on multiple occasions and eventually could migrate up to HoloViews under two conditions:

a) We decide to generalize the annotators further
b) We decide we actually want to ship bokeh extensions as part of HoloViews itself

@philippjfr philippjfr changed the title Port custom tools from EarthSim Port custom tools, streams and links from EarthSim Nov 4, 2019
@jbednar
Copy link
Member

jbednar commented Nov 5, 2019

@philippjfr and I have been discussing this, and I believe the plan is (which Philipp can correct if needed):

  • For now, move the tools here into GeoViews so that they become available for use immediately
  • All tools except for PolyVertexEditTool are useful for any Bokeh drawing-tools user, and we will try to get those into Bokeh itself.
  • PolyVertexEditTool would stay here in GeoViews indefinitely, as it's a specialized geo-specific tool
  • HoloViews won't need any new tools and thus will continue not to need any Bokeh extensions.
  • The main documentation and examples will be in HoloViews, with some geo-specific examples here.

@philippjfr
Copy link
Member Author

@kcpevey You might also want to test this PR which adds geo-support for the annotators along with some of the other custom tools.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.9%) to 43.548% when pulling c915ce2 on philippjfr/custom_tools into ef14244 on master.

@philippjfr
Copy link
Member Author

I'll merge for now so I can test releasing the custom bokeh models.

@philippjfr philippjfr merged commit f19cb0d into master Jan 4, 2020
@philippjfr philippjfr deleted the philippjfr/custom_tools branch March 22, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants