Adding ESRI Ocean tile layers #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding ESRI Ocean Base and Ocean Reference layers
|
This is great thanks! |
|
@philippjfr or @jbednar These layers need to be tested and please check the attributions -- I wasn't quite sure how those worked. |
|
I just tested and they work okay, but I'm still not sure about whether I did the attributions correctly. |
|
Yes, that all looks correct to me. |
|
The attributions code isn't great tbh, but it does the job so far. |
philippjfr
reviewed
May 3, 2019
|
I requested one small change otherwise happy to merge. |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ESRI Ocean Base and Ocean Reference layers