Small maintenance (#675)

holoviz · Sep 26, 2023 · 6bd9414 · 6bd9414
1 parent 88bcdba
commit 6bd9414
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 19 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -16,22 +16,12 @@ concurrency:
 
 jobs:
   pre_commit:
-    name: Run pre-commit hooks
+    name: Run pre-commit
     runs-on: 'ubuntu-latest'
     steps:
-      - uses: actions/checkout@v3
-        with:
-          fetch-depth: "1"
-      - name: set PY
-        run: echo "PY=$(python -VV | sha256sum | cut -d' ' -f1)" >> $GITHUB_ENV
-      - uses: actions/cache@v3
-        with:
-          path: ~/.cache/pre-commit
-          key: pre-commit|${{ env.PY }}|${{ hashFiles('.pre-commit-config.yaml') }}
-      - name: pre-commit
-        uses: pre-commit/action@v3.0.0
-  test_suite:
-    name: Pytest on ${{ matrix.os }} with Python ${{ matrix.python-version }}
+      - uses: holoviz-dev/holoviz_tasks/pre-commit@v0.1a17
+  unit_test_suite:
+    name: Unit tests on Python ${{ matrix.python-version }}, ${{ matrix.os }}
     needs: [pre_commit]
     runs-on: ${{ matrix.os }}
     strategy:
@@ -50,7 +40,7 @@ jobs:
       SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"
       USE_PYGEOS: '0'
     steps:
-      - uses: holoviz-dev/holoviz_tasks/install@v0.1a15
+      - uses: holoviz-dev/holoviz_tasks/install@v0.1a17
         with:
           name: unit_test_suite
           python-version: ${{ matrix.python-version }}

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -17,13 +17,13 @@ repos:
       - id: trailing-whitespace
         exclude: \.svg$
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.0.283
+    rev: v0.0.291
     hooks:
       - id: ruff
         args: [geoviews]
         files: geoviews/
   - repo: https://github.com/hoxbro/clean_notebook
-    rev: v0.1.10
+    rev: v0.1.11
     hooks:
       - id: clean-notebook
   - repo: https://github.com/codespell-project/codespell

diff --git a/scripts/download_data.sh b/scripts/download_data.sh
@@ -1,5 +1,7 @@
 #!/usr/bin/env bash
 
+set -eux pipefail
+
 bokeh sampledata
 
 HERE=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
@@ -8,8 +10,9 @@ geoviews fetch-data --path="$HERE/../examples"
 python -c "
 try:
     import geodatasets as gds
-    gds.get_path('geoda airbnb')
-    gds.get_path('nybb')
 except ImportError:
     pass
+else:
+    gds.get_path('geoda airbnb')
+    gds.get_path('nybb')
 "