Added collections of named colormaps, attribute access #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixes #4, sorting the named dictionaries so that options are in a good order in the above list. |
philippjfr
reviewed
Sep 23, 2017
assets/CET_to_py.py
Outdated
| """Ordered dictionary with attribute access (e.g. for tab completion)""" | ||
| def __getattr__(self, name): return self[name] | ||
| def __delattr__(self, name): del self[name] | ||
| def __setattr__(self, name, value): self[name] = value |
There was a problem hiding this comment.
Should this also have a __dir__ method for tab completion or would that be too cluttered:
def __dir__(self): return self.keys()
colorcet/__init__.py
Outdated
| """Ordered dictionary with attribute access (e.g. for tab completion)""" | ||
| def __getattr__(self, name): return self[name] | ||
| def __delattr__(self, name): del self[name] | ||
| def __setattr__(self, name, value): self[name] = value |
There was a problem hiding this comment.
Comment above probably applies more here, a __dir__ might be nice.
There was a problem hiding this comment.
The first one is the source code for the second one, so sure, I'll add that. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc collected fixes/improvements:
Example of those last two: