Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish dev nbsite to a new tooling_dev channel #316

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

maximlt
Copy link
Collaborator

@maximlt maximlt commented Sep 27, 2024

I would like to be able to build hvPlot's docs without any HoloViz dev release but with a dev release of nbsite. This is currently not possible (or at least not easily). With this PR nbsite will get additionally published to tooling_dev (dev releases) and tooling (main releases) channels.

Copy link
Collaborator

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we need two channels for this, as it is an internal tool on our channel.

But I don't have a strong opinion either way—other than if we want two channels, we should apply my suggested change.

.github/workflows/build.yaml Outdated Show resolved Hide resolved
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
@maximlt
Copy link
Collaborator Author

maximlt commented Sep 27, 2024

I don't know if we need two channels for this, as it is an internal tool on our channel.

Do you mean 1 channel instead? Just tooling_dev? Might be fine yes.

@hoxbro
Copy link
Collaborator

hoxbro commented Sep 27, 2024

Do you mean 1 channel instead? Just tooling_dev? Might be fine yes.

Yes, maybe just tooling to keep it short.

@maximlt
Copy link
Collaborator Author

maximlt commented Sep 27, 2024

Do you mean 1 channel instead? Just tooling_dev? Might be fine yes.

Yes, maybe just tooling to keep it short.

Hmm sometimes I may want pyviz/label/dev but not a dev version of nbsite.

@hoxbro
Copy link
Collaborator

hoxbro commented Sep 27, 2024

Hmm sometimes I may want pyviz/label/dev but not a dev version of nbsite.

Your suggested changes won't solve that either, right? As nbsite is still upload to dev.

@maximlt
Copy link
Collaborator Author

maximlt commented Sep 27, 2024

Ah yes true 🤦 In which case I'd suggest no longer publishing nbsite to dev and main.

@hoxbro
Copy link
Collaborator

hoxbro commented Sep 27, 2024

I'm not a fan of that. Wouldn't it be easy enough to pin nbsite in that case?

@maximlt
Copy link
Collaborator Author

maximlt commented Sep 30, 2024

I'm not a fan of that. Wouldn't it be easy enough to pin nbsite in that case?

It depends on what you want to achieve. Pinning is imo an okay solution short term but is annoying long term. I've had a quick look at these repos and saw that most of them build the docs with the pyviz/label/dev channel, I'm not sure that's the right thing to do? Perhaps this channel was set up at some point to get a dev release of nbsite and then forgotten, I'm not sure. I also noticed nbsite is pinned to 0.8.4 on Param's doc build.

  • HoloViews: pyviz/label/dev
  • GeoViews: pyviz/label/dev
  • Panel: pyviz/label/dev
  • Datashader: pyviz/label/dev
  • hvPlot: conda-forge with dev install of nbsite from pip
  • Lumen: pyviz/label/dev
  • Param: nbsite ==0.8.4" from pip

@hoxbro
Copy link
Collaborator

hoxbro commented Oct 1, 2024

Pinning is imo an okay solution short term but is annoying long term

But we control the whole chain, so we can always push a fix if we need it.

build the docs with the pyviz/label/dev channel, I'm not sure that's the right thing to do?

I feel like we have this talk every six months or so 🙃

In my opinion, it is not a black-and-white case. Sometimes, you need to have the latest dev release for one of our package to be able to publish the documentation. Sometimes, it doesn't matter if it is dev version or full release, and sometimes, we should use the full release.

I don't think we can make a definite rule, as it will almost always depend on the case.

Perhaps this channel was set up at some point to get a dev release of nbsite and then forgotten

This only argues for a tooling-only channel, not the removal of nbsite for the existing channels, IMO.

@maximlt
Copy link
Collaborator Author

maximlt commented Oct 1, 2024

@hoxbro are you okay with a tooling_dev channel only?

@maximlt maximlt merged commit 2458a4e into main Oct 1, 2024
5 checks passed
@maximlt maximlt deleted the publish_tooling_channel branch October 1, 2024 10:30
@maximlt maximlt changed the title Publish nbsite to two new channels: tooling_dev and tooling Publish dev nbsite to a new tooling_dev channel Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants