-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish dev nbsite to a new tooling_dev channel #316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we need two channels for this, as it is an internal tool on our channel.
But I don't have a strong opinion either way—other than if we want two channels, we should apply my suggested change.
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
Do you mean 1 channel instead? Just tooling_dev? Might be fine yes. |
Yes, maybe just tooling to keep it short. |
Hmm sometimes I may want pyviz/label/dev but not a dev version of nbsite. |
Your suggested changes won't solve that either, right? As nbsite is still upload to dev. |
Ah yes true 🤦 In which case I'd suggest no longer publishing nbsite to |
I'm not a fan of that. Wouldn't it be easy enough to pin nbsite in that case? |
It depends on what you want to achieve. Pinning is imo an okay solution short term but is annoying long term. I've had a quick look at these repos and saw that most of them build the docs with the
|
But we control the whole chain, so we can always push a fix if we need it.
I feel like we have this talk every six months or so 🙃 In my opinion, it is not a black-and-white case. Sometimes, you need to have the latest dev release for one of our package to be able to publish the documentation. Sometimes, it doesn't matter if it is dev version or full release, and sometimes, we should use the full release. I don't think we can make a definite rule, as it will almost always depend on the case.
This only argues for a tooling-only channel, not the removal of nbsite for the existing channels, IMO. |
@hoxbro are you okay with a |
I would like to be able to build hvPlot's docs without any HoloViz dev release but with a dev release of nbsite. This is currently not possible (or at least not easily). With this PR nbsite will get additionally published to
tooling_dev
(dev releases) andtooling
(main releases) channels.