solution of issue #9

[katerinaonusk]

Adds mongo DB support for property persistence for device restarts. Solves issue #9.

[VigneshVSV]

Hi,

Thanks a lot for the PR. I get back to you on Friday and Saturday with feedback or approval as I need to test it with a mongo instance.

[katerinaonusk]

Hi @VigneshVSV,

No problem at all - just let me know once you’ve had a chance to test it.

[VigneshVSV]

Hi @katerinaonusk ,

My review is complete. Just some minor cosmetic changes and I think it should be good to go.

[katerinaonusk]

Hi @VigneshVSV,

Thanks a lot for the detailed review!
I’ve gone through all your comments and will work on them as soon as possible.

• add pymongo to pyproject.toml as a core dependency,
• improve code formatting and move the class towards the end of the file,
• restore the abstract base class for the Serializer,
• remove unnecessary use of pickle and keep JSON as the default,
• keep the current kwargs handling without extra preprocessing,
• fix the duplicate setUpClass definition in the tests,
• move the MongoDB tests to tests/working - yet to be integrated/test_07_properties_mongodb.py.

I’ll try to complete these changes soon so we can run the pipeline and move forward with the merge.

[VigneshVSV]

@katerinaonusk , feel free to take your time. I have to also add a docker compose file in another project with mongo in it. So it should take a few days for all of this to come together.

Also, put a star if you like the project and tell your IoT, electronics & web developer friends about the project.

[katerinaonusk]

Hi @VigneshVSV,
I’ve made a pull request that fixes this issue.
I updated everything based on your feedback, so please check if it looks good now.

Thanks!

[VigneshVSV]

Hi @VigneshVSV,
I’ve made a pull request that fixes this issue.
I updated everything based on your feedback, so please check if it looks good now.

Thanks!

👋 I will check it on Friday

[VigneshVSV]

Hi @katerinaonusk ,

Its even better than before and all comments were addressed. I will merge this now and publish it tomorrow morning.

Thanks a lot!