Make getter, setter & deleter decorators to return the `Property` or `Parameter` instance instead of returning `fget`, `fset` and `fdel` methods

[VigneshVSV]

The Property getter, setter & deleter methods need to have a different name than the property itself, otherwise the property instance will be replaced.

This is contradictory to python's own property behaviour where the getter decorator returns the property instead of the getter method and the name must match to the name of the property. However, an explicitly differently named getter/setter/deleter can be passed in the __init__ of python's property. This is how one can have control over the naming styles in python's property.

We should replicate this behaviour. Also the reason of not using python's property is already described in the documentation - python's own property does not allow foreign attributes as its a C implementation.

Rough number of steps:

• make our getter, setter, deleter return self or Parameter or Property instance
• in our entire code base, where Properties and Parameters are used with getters/setters/deleters, rename the getter, setter and deleters to use the Parameter's name.
• make sure tests also follow same convention

[EstebanGZam]

Hi @VigneshVSV, Can I take this issue?

Also:

1. Do the current tests work without the proposed adjustments?
2. How many/which tests would need to be modified?
3. Would new tests be needed to validate the changes?

[VigneshVSV]

Hi @EstebanGZam,

This is a breaking change, and tests need to be modified as well. So the current tests will not work. The main file is test_property.py under tests folder, although I expect stuff to break in a few different places (but not hard to fix - rather straightforward fixes).

One might have to comb through each file for getter and setter decorators (code editor search function can be useful) and modify the code if necessary.

It would be nice to have one additional test where this update is explicitly tested. may be like the following:

• create a property without getter and setter
• assert the property is of instance property
• create a setter and getter, assert that the returned value is also the same property

Hardly 10-20 lines.

Just let me know if you still interested, I can assign the issue to you.

This issue will be released under version 0.3.0 (i.e. not under 0.2) as its breaking.

[EstebanGZam]

Sure! I'd be happy to take care of this issue. However, I'll first finish the necessary adjustments to close issue #64, and then I'll focus on this one. Does that sound okay?

I think I'll be able to start working on the revisions you suggested in a day or two.

[VigneshVSV]

Hi @EstebanGZam, not a problem. Sorry didnt look at the comment as I didn't get a notification.