Skip to content

Add ruff code style check CI/CD job #102

@VigneshVSV

Description

@VigneshVSV

Codestyling should be enforced with ruff. There is already a .vscode file that has recommentations to reformat the file according to ruff standards with line spacing 120 using the VS code ruff extension.

However, we are still far away from following all standards. There are many imports that are unused, for example. Some files are still not formatted correctly.

There are two steps:

  • Create a merge request with all code files formatted according to the ruff extension. In this way, the baseline is set and the changes are not too many in further MRs. If possible:
    • remove unused imports and wildcard imports
    • change typing module members to not use typing namespace prefix - in other words, if there is a signature typing.Optional[int], make it Optional[int]
  • In a separate merge request
    • add ruff as a CI/CD job in a codestyle stage
    • make sure the job passes in the opened MR

Metadata

Metadata

Assignees

Labels

beginnerbeginner level good first issues, usually issues that can worked on without skimming the whole repogood first issueGood for newcomers

Type

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions