-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement/holo 603 gas optimization combine address mappings #82
base: testnet
Are you sure you want to change the base?
Improvement/holo 603 gas optimization combine address mappings #82
Conversation
@ACC01ADE I realize the gas savings from this might not be much as the values are not used in the same function and don't fit into the same slot, but this was my way of picking something easy up to get more comfortable updating the contracts before getting into more complicated stuff. If we feel that the potential gas savings don't justify the introduction of the new struct types / ergonomic changes of accessing the values, it's fine to not integrate these changes. lmk what you think |
You can see some calls that have some gas savings in the screenshots below |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…bine-address-mappings
Describe Changes
Checklist before requesting a review