Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor 05 cross chain configuration tests #346

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Refactor 05 cross chain configuration tests #346

merged 5 commits into from
Jul 2, 2024

Conversation

mmvazzano
Copy link
Contributor

Describe Changes

  • Modify section headings using Comment Divider
  • Get deployer address from Constants.sol
  • Removed the unused deployTestSampleERC20 function
  • Three new tests (previously omitted) have been written and successfully passed.
  • Two other tests were written (previously skipped) but still failed.
  • It remains to check whether the Holpographer addresses should be identical or different in the two chains.

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code styles have been enforced
  • All Foundry tests are passing

fgregoribattista
fgregoribattista approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@fgregoribattista fgregoribattista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one thing. The rest its ok for me

test/foundry/deploy/05_cross-chain_configuration_tests_lq_l2.sol Outdated Show resolved Hide resolved
sogoiii
sogoiii approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@sogoiii sogoiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sogoiii sogoiii merged commit be0ccb3 into develop Jul 2, 2024
3 checks passed
@sogoiii sogoiii deleted the refactor_05_cross-chain_configuration_tests branch July 2, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sogoiii sogoiii sogoiii approved these changes

@fgregoribattista fgregoribattista fgregoribattista approved these changes

@djaciel djaciel djaciel approved these changes

Assignees

@mmvazzano mmvazzano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmvazzano @sogoiii @fgregoribattista @djaciel