Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 19_ERC721H_tests.t.sol #327

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

mmvazzano
Copy link
Contributor

Add 19_ERC721H_tests.t.sol
The 4 skipped tests check that some functions are private, but the contract shows that they are not.

Copy link
Contributor

@fgregoribattista fgregoribattista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work Mer, only non-blocking comments

test/foundry/deploy/19_ERC721H_tests.t.sol Show resolved Hide resolved
test/foundry/deploy/19_ERC721H_tests.t.sol Outdated Show resolved Hide resolved
test/foundry/deploy/19_ERC721H_tests.t.sol Outdated Show resolved Hide resolved
test/foundry/deploy/19_ERC721H_tests.t.sol Outdated Show resolved Hide resolved
Copy link
Contributor

@djaciel djaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sogoiii sogoiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sogoiii sogoiii merged commit baf5904 into holographxyz:develop Jun 11, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants