Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create 12_holograph_genesis_tests.t.sol #319

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Create 12_holograph_genesis_tests.t.sol #319

merged 5 commits into from
Jun 4, 2024

Conversation

mmvazzano
Copy link
Contributor

@mmvazzano mmvazzano commented May 28, 2024 •
edited by fgregoribattista
Loading

Describe Changes

  • Migration of the test 12_holograph_genesis_tests to foundry.
  • Test testAllowInheritedContractToCallFnApproveDeployerMock is skipped, as the mock contract it uses has the saving and loading of the signature pending (todo).

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code styles have been enforced
  • All Foundry tests are passing

@fgregoribattista fgregoribattista marked this pull request as ready for review May 29, 2024 20:46
djaciel
djaciel approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@djaciel djaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sogoiii
sogoiii approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@sogoiii sogoiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

alexanderattar
alexanderattar requested changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@alexanderattar alexanderattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I get an error with trying to compile

@alexanderattar alexanderattar merged commit ca7ba5c into holographxyz:develop Jun 4, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-marc lucas-marc lucas-marc left review comments

@sogoiii sogoiii sogoiii approved these changes

@alexanderattar alexanderattar alexanderattar approved these changes

@djaciel djaciel djaciel approved these changes

Assignees

@mmvazzano mmvazzano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mmvazzano @sogoiii @alexanderattar @djaciel @lucas-marc @fgregoribattista