Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature / HOLO 1495 CustomContract Reveal CSV File #272

Merged
merged 8 commits into from
May 2, 2024
Merged

Feature / HOLO 1495 CustomContract Reveal CSV File #272

merged 8 commits into from
May 2, 2024

Conversation

BravoNatalie
Copy link
Contributor

@BravoNatalie BravoNatalie commented Apr 17, 2024 •
edited
Loading

Describe Changes

I made this more better by doing ...

  • Implemented scripts for CustomERC721 contract:
    • Enable batch encryption of NFTs
    • Facilitate contract deployment
    • Simplify NFT reveal process
  • Integrated scripts for CountdownERC721 contract:
    • Enable contract deployment
    • Provide functionality to set owner
    • Allow minting of NFTs
    • Enable NFT purchase functionality

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code styles have been enforced
  • All Hardhat tests are passing

@BravoNatalie BravoNatalie changed the base branch from develop to feature/HOLO-1480-delay-reveal-countdown-erc721 April 17, 2024 17:07
@BravoNatalie BravoNatalie force-pushed the feature/holo-1495-customcontract-reveal-csv-file branch 4 times, most recently from c58ae3c to 268304c Compare April 24, 2024 14:46
@BravoNatalie BravoNatalie force-pushed the feature/holo-1495-customcontract-reveal-csv-file branch 4 times, most recently from a2f067d to 1789b1c Compare April 30, 2024 13:44
@BravoNatalie BravoNatalie force-pushed the feature/holo-1495-customcontract-reveal-csv-file branch from 1789b1c to 5d76b2d Compare April 30, 2024 18:11
@BravoNatalie BravoNatalie changed the base branch from feature/HOLO-1480-delay-reveal-countdown-erc721 to feature/HOLO-1480-countdown-erc721 April 30, 2024 19:55
@BravoNatalie BravoNatalie force-pushed the feature/holo-1495-customcontract-reveal-csv-file branch from c37cbd6 to f5df9f2 Compare April 30, 2024 20:28
@BravoNatalie BravoNatalie force-pushed the feature/holo-1495-customcontract-reveal-csv-file branch from 541722d to 17b1fb6 Compare May 1, 2024 16:58
@BravoNatalie BravoNatalie marked this pull request as ready for review May 1, 2024 17:02
sogoiii
sogoiii requested changes May 1, 2024
View reviewed changes
Copy link
Contributor

@sogoiii sogoiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great start! We can work on improving the tutorials. 👍

scripts/countdown_erc721/README.md Outdated Show resolved Hide resolved
scripts/countdown_erc721/README.md Outdated Show resolved Hide resolved
scripts/countdown_erc721/README.md Outdated Show resolved Hide resolved
scripts/custom_delay_reveal_erc721/utils.ts Show resolved Hide resolved
deploy/30_verify.ts Outdated Show resolved Hide resolved
scripts/countdown_erc721/README.md Show resolved Hide resolved
scripts/countdown_erc721/4-purchase.ts Outdated Show resolved Hide resolved
scripts/countdown_erc721/4-purchase.ts Show resolved Hide resolved
scripts/countdown_erc721/README.md Outdated Show resolved Hide resolved
@alexanderattar alexanderattar merged commit f0324cd into feature/HOLO-1480-countdown-erc721 May 2, 2024
@alexanderattar alexanderattar deleted the feature/holo-1495-customcontract-reveal-csv-file branch May 2, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sogoiii sogoiii sogoiii requested changes

@alexanderattar alexanderattar alexanderattar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BravoNatalie @sogoiii @alexanderattar