Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Enhancement clickable post links #84

Merged
science-girl merged 10 commits into from
May 24, 2018
Merged

Enhancement clickable post links #84

science-girl merged 10 commits into from
May 24, 2018

Conversation

@science-girl
Copy link
Contributor

@science-girl science-girl commented May 23, 2018 •
edited
Loading

  • URLs are clickable links
  • 'Close' button on 'Follow' page
  • UI-automation tests
  • more UI enhancements from Micah (match Celestial's wire-frames and UI suggestions)

@zippy zippy added the review label May 24, 2018
@science-girl science-girl merged commit e212551 into develop May 24, 2018
@science-girl science-girl deleted the enhancement-clickablePostLinks branch May 24, 2018 03:43
@lucksus
Copy link
Collaborator

lucksus commented May 24, 2018

Hm, seems this was merged with only one approval.. ;)
Looks good, but I would have asked to split these different concerns into different PRs. Not because it really is a problem with this set of features (which are all small enough to not render this PR super large) but more like an example of how to best use pull-requests etc..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lucksus lucksus Awaiting requested review from lucksus

@bboyatwork bboyatwork Awaiting requested review from bboyatwork

@Connoropolous Connoropolous Awaiting requested review from Connoropolous

1 more reviewer

@zippy zippy zippy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@science-girl @lucksus @zippy