Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Conversation

@bboyatwork
Copy link
Contributor

Updating clutter UI style - addressing issue #72 cc @science-girl

Proposing some UI style updates for the clutter experience.
Addressing issue #72
@bboyatwork bboyatwork requested a review from science-girl May 22, 2018 23:28
Copy link
Contributor

@science-girl science-girl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much improved 👍

Copy link
Collaborator

@lucksus lucksus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several files in here that should not be under version control / not have been commited. Basically everything in the sub-directory clutter needs to be removed before merge.

@@ -0,0 +1 @@
alchemicalu@Micahs-MBP No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file should be under version control.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've deleted the unnecessary sub-directory that address this and the follow issues / changes needed @lucksus

"PropertiesSchemaFile": "properties_schema.json",
"BasedOn": {
"H": null
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old syntax for "BasedOn" which does not work with latest Holochain version.
Just remove this property.

clutter/priv.key Outdated
@@ -0,0 +1 @@
`alchemicalu@Micahs-MBP1234567890C�0��)sn祎̨�彷��$���.W-��C�0��)sn祎̨�彷��$���.W-�� No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should definitely not be under version control :D

Copy link
Member

@zippy zippy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason I thought these tweaks would include a close button on the Follow pane. Did I miss that?

Also on wide screens, the gap between the bottom of the header area and the meows gets too big. Image attached.

@zippy
Copy link
Member

zippy commented May 23, 2018

2018-05-23-152219_1197x538_scrot

Doesn't that seem like too much?

Closed gap area between meow box and feed.
@bboyatwork
Copy link
Contributor Author

I adjusted that gap area with my latest commit @zippy

@zippy
Copy link
Member

zippy commented May 23, 2018

woot looks good @bboyatwork

@zippy zippy merged commit b3c1fcb into develop May 23, 2018
@zippy zippy removed the review label May 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants