-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
Proposing some UI style updates for the clutter experience.
Addressing issue #72
science-girl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much improved 👍
lucksus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several files in here that should not be under version control / not have been commited. Basically everything in the sub-directory clutter needs to be removed before merge.
clutter/agent.txt
Outdated
| @@ -0,0 +1 @@ | |||
| alchemicalu@Micahs-MBP No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this file should be under version control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've deleted the unnecessary sub-directory that address this and the follow issues / changes needed @lucksus
clutter/dna/dna.json
Outdated
| "PropertiesSchemaFile": "properties_schema.json", | ||
| "BasedOn": { | ||
| "H": null | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old syntax for "BasedOn" which does not work with latest Holochain version.
Just remove this property.
clutter/priv.key
Outdated
| @@ -0,0 +1 @@ | |||
| `alchemicalu@Micahs-MBP1234567890C�0��)sn祎̨�彷��$���.W-��C�0��)sn祎̨�彷��$���.W-�� No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should definitely not be under version control :D
zippy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason I thought these tweaks would include a close button on the Follow pane. Did I miss that?
Also on wide screens, the gap between the bottom of the header area and the meows gets too big. Image attached.
|
I adjusted that gap area with my latest commit @zippy |
|
woot looks good @bboyatwork |

Updating clutter UI style - addressing issue #72 cc @science-girl