Skip to content

Commit

Permalink
Fix link buttons not appearing in collapsed mode (#9)
Browse files Browse the repository at this point in the history
  • Loading branch information
Davit-G authored Apr 28, 2024
1 parent 44016b5 commit 104572f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ The following changes were made in this repo:

Bugs I found (or introduced hehe):

- The Link buttons under the input/output knobs disappear when the reels are hidden.
- [FIXED] ~~The Link buttons under the input/output knobs disappear when the reels are hidden.~~
- Sometimes there is an extremely loud glitch. Not sure yet what causes this, maybe some uninitialized memory. Hard to reproduce.
- The hacky way I've implemented the Link Input/Output mode may be problematic. Sometimes this gives an assertion on `beginGesture` being called twice. Not a massive problem but not great either.
- When restoring state, the Shame knob's cross is in the right position but the colored track isn't shown.
Expand Down
4 changes: 4 additions & 0 deletions Source/PluginEditor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,10 @@ void KissOfShameAudioProcessorEditor::setReelMode(bool showReels)
vuMeterR.setTopLeftPosition(vuMeterR.getX(), vuMeterR.getY() + adjustment);
shameKnobImage.setTopLeftPosition(shameKnobImage.getX(), shameKnobImage.getY() + adjustment);

// Link Buttons
linkIOButtonL.setTopLeftPosition(linkIOButtonL.getX(), linkIOButtonL.getY() + adjustment);
linkIOButtonR.setTopLeftPosition(linkIOButtonR.getX(), linkIOButtonR.getY() + adjustment);

if (showReels) {
faceImage.setAnimationImage(BinaryData::FaceWithReels_png, BinaryData::FaceWithReels_pngSize);
faceImage.setDimensions(0, 0, 960, 703);
Expand Down

0 comments on commit 104572f

Please sign in to comment.