trie: Remove buggy StackTrie #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
pushed a commit
that referenced
this pull request
Mar 18, 2024
* Experimental: EVMLogger fixed error code * First pass of review * Move error to `core/vm/errors.go`, ensure also we strictly implement `rpc.Error` (without depending on it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StackTrie was a nice experiment and I was keeping it around to remember some of the optimization tricks that I put in there. It is also very buggy and has since then been superseded by ReStackTrie.
This PR also include a bugfix that was dropped from the previous bugfix PR.