Skip to content

Allow the drop to be cancelled #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Allow the drop to be cancelled #31

merged 1 commit into from
Nov 5, 2018

Conversation

rojtjo
Copy link
Contributor

@rojtjo rojtjo commented Oct 31, 2018

Hi there,

First of all thank you for making this great component!

I'm building a component to manage (nested) menu items and use your component to handle the sorting of the items. In my use case I needed to be able to cancel a drop if the level is greater than a certain number.

In order to do this I added an additional event (beforedrop) which is fired just before a drop is handled. It sends the same data as the drop event except that the native event is replaced by a cancel function. Once the cancel function is called it will halt the execution of the drop.

Let me know if you'd like me to change something or add documentation for it.

Cheers,
Roj

@holiber holiber self-assigned this Nov 1, 2018
@holiber
Copy link
Owner

holiber commented Nov 5, 2018

Hi, thank you for PR.

@holiber holiber merged commit 24dc1fd into holiber:master Nov 5, 2018
@dadigu
Copy link

dadigu commented Dec 4, 2018

Hi, when will this feature be tagged in a new release? I could really use this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants