Skip to content

add 'empty-node' slot #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 11, 2018
Merged

add 'empty-node' slot #25

merged 5 commits into from
Oct 11, 2018

Conversation

lazylester
Copy link
Contributor

to show a message when a folder (= node that is !isLeaf) is expanded and has no children

b/c it's easier to handle this within Sl-Vue-Tree than try to hack it in from outside.
@holiber
Copy link
Owner

holiber commented Oct 4, 2018

Thanks for PR. Unfortunaltely this code provides breaking changes. Every user that will get an updated version of sl-vue-tree component will see an 'empty' message for empty nodes. So you have to remove the default slot content.

@lazylester
Copy link
Contributor Author

you make a good point @holiber hopefully the additional commits are acceptable

@holiber holiber self-assigned this Oct 9, 2018
@holiber holiber added the enhancement New feature or request label Oct 9, 2018
@holiber holiber merged commit af1aefd into holiber:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants