Merged
Conversation
Owner
|
This is awesome! Thanks @edmondop :D |
holdenk
added a commit
that referenced
this pull request
Apr 25, 2023
Owner
|
Ah slight problem with the tests. Let me get the tests running on PRs later this week and we can redo. |
Contributor
Author
|
Tests were running for me locally but I couldn't trigger the build on the CI. Let me look into those...
|
Contributor
Author
|
I see, the problem is only with the distribution not being set in the github workflows. What JDK do you want to use?open jdk? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for JDK 17 by adding exceptions to new visibility rules introduced by Java 17. The exceptions are taken from the Spark official repository apache/spark#34153
Fixes #358