support for plugins where the init method doesn't return a Promise

hoermannpaul · Mar 14, 2019 · 6410ed1 · 6410ed1
1 parent 5301a9e
commit 6410ed1
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 20 deletions.
diff --git a/js/reveal.js b/js/reveal.js
@@ -539,29 +539,34 @@
 
 		var pluginsToInitialize = Object.keys( plugins ).length;
 
+		var afterPlugInitialized = function() {
+			if( --pluginsToInitialize === 0 ) {
+				loadAsyncDependencies();
+			}
+		};
+
 		for( var i in plugins ) {
 
 			var plugin = plugins[i];
 
-			// If the plugin has an 'init' method, initialize and
-			// wait for the callback
+			// If the plugin has an 'init' method, invoke it
 			if( typeof plugin.init === 'function' ) {
-				plugin.init().then( function() {
-					if( --pluginsToInitialize === 0 ) {
-						loadAsyncDependencies();
-					}
-				} );
+				var callback = plugin.init();
+
+				// If the plugin returned a Promise, wait for it
+				if( callback && typeof callback.then === 'function' ) {
+					callback.then( afterPlugInitialized );
+				}
+				else {
+					afterPlugInitialized();
+				}
 			}
 			else {
-				pluginsToInitialize -= 1;
+				afterPlugInitialized();
 			}
 
 		}
 
-		if( pluginsToInitialize === 0 ) {
-			loadAsyncDependencies();
-		}
-
 	}
 
 	/**

diff --git a/plugin/highlight/highlight.js b/plugin/highlight/highlight.js
diff --git a/plugin/math/math.js b/plugin/math/math.js
@@ -84,8 +84,6 @@ var RevealMath = window.RevealMath || (function(){
 
 			} );
 
-			return Promise.resolve();
-
 		}
 	}
 

diff --git a/plugin/notes/notes.js b/plugin/notes/notes.js
@@ -168,8 +168,6 @@ var RevealNotes = (function() {
 
 			}
 
-			return Promise.resolve();
-
 		},
 
 		open: openNotes

diff --git a/plugin/zoom-js/zoom.js b/plugin/zoom-js/zoom.js
@@ -22,8 +22,6 @@ var RevealZoom = (function(){
 				}
 			} );
 
-			return Promise.resolve();
-
 		}
 	}