Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 4, 2025

Summary

Fixed grammar issues in the localization string resources for both English and Vietnamese translations.

Changes

English (values/strings.xml)

  • Before: "Now is %1s"
  • After: "It is now %1$s"

Improvements:

  1. Grammar correction: Changed "Now is" to "It is now" for proper English grammar
  2. Format specifier fix: Added missing $ in the format specifier (%1$s instead of %1s)

Vietnamese (values-vi/strings.xml)

  • Before: "Bây giờ là %1s"
  • After: "Bây giờ là %1$s"

Improvements:

  1. Format specifier fix: Added missing $ in the format specifier (%1$s instead of %1s)

Why These Changes Matter

  1. Proper English grammar: The phrase "It is now [time]" is grammatically correct, while "Now is [time]" is awkward and non-standard English.

  2. Correct Android format syntax: Android string resources require the positional format specifier to include the $ character (e.g., %1$s, %2$s). While %1s may work in simple cases, %1$s is the correct and recommended format, especially important when dealing with multiple arguments or complex formatting scenarios.

Testing

  • All XML files validated successfully with xmllint
  • String resource is properly used in DemoDateTimeFormatter composable with correct parameter passing
  • No functional changes to the app behavior, only improved string quality

Fixes #10

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Fix strings</issue_title>
<issue_description>Fix grammars of strings</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #10

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: hoc081098 <36917223+hoc081098@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix strings Fix grammar and format specifiers in string resources Oct 4, 2025
Copilot AI requested a review from hoc081098 October 4, 2025 13:54
@hoc081098 hoc081098 marked this pull request as ready for review October 4, 2025 15:10
@hoc081098 hoc081098 merged commit f5cb751 into main Oct 4, 2025
2 checks passed
@hoc081098 hoc081098 deleted the copilot/fix-5dc645b2-6319-425c-8d1d-f1ce95314280 branch October 4, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix strings

2 participants