Fix grammar and format specifiers in string resources #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed grammar issues in the localization string resources for both English and Vietnamese translations.
Changes
English (
values/strings.xml)"Now is %1s""It is now %1$s"Improvements:
$in the format specifier (%1$sinstead of%1s)Vietnamese (
values-vi/strings.xml)"Bây giờ là %1s""Bây giờ là %1$s"Improvements:
$in the format specifier (%1$sinstead of%1s)Why These Changes Matter
Proper English grammar: The phrase "It is now [time]" is grammatically correct, while "Now is [time]" is awkward and non-standard English.
Correct Android format syntax: Android string resources require the positional format specifier to include the
$character (e.g.,%1$s,%2$s). While%1smay work in simple cases,%1$sis the correct and recommended format, especially important when dealing with multiple arguments or complex formatting scenarios.Testing
DemoDateTimeFormattercomposable with correct parameter passingFixes #10
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.comIf you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.