fix few comments

hnnajh · Dec 1, 2023 · 06a1879 · 06a1879
1 parent 79d5733
commit 06a1879
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/examples/chip-tool/commands/discover/Commands.h b/examples/chip-tool/commands/discover/Commands.h
@@ -53,8 +53,8 @@ class Resolve : public DiscoverCommand, public chip::AddressResolve::NodeListene
                         result.mrpRemoteConfig.mIdleRetransTimeout.count());
         ChipLogProgress(chipTool, "   MRP retry interval (active): %" PRIu32 "ms",
                         result.mrpRemoteConfig.mActiveRetransTimeout.count());
-        ChipLogProgress(chipTool, "   Supports Client TCP: %s", result.supportsTcpClient ? "yes" : "no");
-        ChipLogProgress(chipTool, "   Supports Server TCP: %s", result.supportsTcpServer ? "yes" : "no");
+        ChipLogProgress(chipTool, "   Supports TCP Client: %s", result.supportsTcpClient ? "yes" : "no");
+        ChipLogProgress(chipTool, "   Supports TCP Server: %s", result.supportsTcpServer ? "yes" : "no");
         ChipLogProgress(chipTool, "   ICD is operating as: %s", result.isICDOperatingAsLIT ? "LIT" : "SIT");
         SetCommandExitStatus(CHIP_NO_ERROR);
     }

diff --git a/src/lib/dnssd/TxtFields.cpp b/src/lib/dnssd/TxtFields.cpp
@@ -38,6 +38,9 @@ namespace Dnssd {
 
 namespace Internal {
 
+constexpr uint8_t kTCPClient = 1;
+constexpr uint8_t kTCPServer = 2;
+
 namespace {
 
 char SafeToLower(uint8_t ch)
@@ -265,8 +268,8 @@ void FillNodeDataFromTxt(const ByteSpan & key, const ByteSpan & value, CommonRes
         break;
     case TxtFieldKey::kTcpSupported: {
         uint8_t support = Internal::MakeU8FromAsciiDecimal(value);
-        nodeData.supportsTcpClient = (support >> 1 & 0x01) == 0x01;
-        nodeData.supportsTcpServer = (support >> 2 & 0x01) == 0x01;
+        nodeData.supportsTcpClient = (support & (1 << Internal::kTCPClient)) != 0;
+        nodeData.supportsTcpServer = (support & (1 << Internal::kTCPServer)) != 0;
         break;
     }
     case TxtFieldKey::kLongIdleTimeICD: