Skip to content

Update installation script - #951

Closed
ondergormez wants to merge 0 commit into
hneemann:masterfrom
ondergormez:fix/For_Better_Diagnostic_Info_In_Linux_Install
Closed

Update installation script#951
ondergormez wants to merge 0 commit into
hneemann:masterfrom
ondergormez:fix/For_Better_Diagnostic_Info_In_Linux_Install

Conversation

@ondergormez

Copy link
Copy Markdown
  • For linux based distros
  • For better diagnostic info

Output look like this;

onder@debian-onder:~/Downloads/Digital$ ./install.sh 
Installation starting...
Generating temporary folder '/tmp/tmp.JCgdkC73Fw'...
Copying files...
'/tmp/tmp.JCgdkC73Fw/digital-simulator.desktop' -> '/home/onder/.local/share/applications/digital-simulator.desktop'
'/home/onder/Downloads/Digital/linux/digital-simulator.xml' -> '/home/onder/.local/share/mime/packages/digital-simulator.xml'
Removing temporary folder '/tmp/tmp.JCgdkC73Fw' and its contents...
removed '/tmp/tmp.JCgdkC73Fw/digital-simulator.desktop'
removed directory '/tmp/tmp.JCgdkC73Fw'
Updating mime database...
'Digital' installed successfully
onder@debian-onder:~/Downloads/Digital$

@ondergormez

Copy link
Copy Markdown
Author

Hello there,

Is there anything you want to be done for this pull request?

Best regards,
Önder

@hneemann

hneemann commented May 4, 2022

Copy link
Copy Markdown
Owner

I'm not sure if set -e is a good idea.

See http://mywiki.wooledge.org/BashFAQ/105

@ondergormez

Copy link
Copy Markdown
Author

Sorry for the delay.
Is there anything else to do?

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Base: 56.7% // Head: 56.6% // Decreases project coverage by -0.0% ⚠️

Coverage data is based on head (54dcaf7) compared to base (51cc9f0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             master    #951     +/-   ##
==========================================
- Coverage      56.7%   56.6%   -0.1%     
- Complexity     6548    6567     +19     
==========================================
  Files           680     679      -1     
  Lines         35314   35440    +126     
  Branches       4748    4784     +36     
==========================================
+ Hits          20030   20073     +43     
- Misses        14080   14159     +79     
- Partials       1204    1208      +4     
Impacted Files Coverage Δ
...mann/digital/gui/components/terminal/Terminal.java 78.7% <0.0%> (-7.5%) ⬇️
...va/de/neemann/digital/draw/shapes/ButtonShape.java 54.1% <0.0%> (-5.3%) ⬇️
...java/de/neemann/digital/draw/elements/Circuit.java 52.2% <0.0%> (-1.7%) ⬇️
src/main/java/de/neemann/digital/core/Model.java 64.8% <0.0%> (-0.9%) ⬇️
...main/java/de/neemann/digital/core/element/Key.java 77.7% <0.0%> (-0.7%) ⬇️
src/main/java/de/neemann/digital/gui/Main.java 1.4% <0.0%> (-0.1%) ⬇️
...emann/digital/gui/components/CircuitComponent.java 1.8% <0.0%> (-0.1%) ⬇️
.../de/neemann/digital/gui/remote/DigitalHandler.java 0.0% <0.0%> (ø)
.../neemann/digital/gui/components/EditorFactory.java 0.0% <0.0%> (ø)
...mann/digital/gui/components/SingleValueDialog.java 0.0% <0.0%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ondergormez
ondergormez force-pushed the fix/For_Better_Diagnostic_Info_In_Linux_Install branch from 54dcaf7 to 6766367 Compare December 20, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants