Update to new zap api #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it emits json, not ltsv.
because the source directory is different.
hnakamur
force-pushed
the
update_to_new_zap_api
branch
from
7d89055
to
369467a
Compare
I'd like to compare results to LTSVEnder EncodeEntry results
hnakamur
force-pushed
the
update_to_new_zap_api
branch
from
f60cf8d
to
932d2db
Compare
hnakamur
force-pushed
the
update_to_new_zap_api
branch
from
932d2db
to
dc74509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed today that I was mentioned at uber-go/zap#253 (comment)
So here is a pull request to update the LTSV encoder to the new zap APIs.
Note to users of this package.
I'm afraid this pull request breaks API compatibility.
I'm sorry.
Please update your code.
Thanks.