-
Notifications
You must be signed in to change notification settings - Fork 3
NOJIRA enforce scala3 syntax #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Ah, now it's using the quiet syntax for the ifs in the project files, the project won't load since that's 2.12. Looking to see if there's a way around that now. |
|
Seems sbt is happy with asterisk and question mark wildcards, but not with the quiet control syntax. I've suppressed scalafmt in the two cases in the project files where it would have otherwise changed; it'll likely come up during the eventual sbt 2 migration. Then I added a dialect to scalafix, to avoid it moving the syntax back when sorting imports. |


This PR adds a rewrite flag to scalafmt to ensure we use the Scala 3 syntax going forward. This will avoid a moment in the future where the Scala 2 syntax (e.g. underscore wildcard imports) are removed, and ensure consistency in the style used across the codebase.
We already have this flag in place for the stubs, and it's being added to the frontend and backend as part of the inflight migration work.
There are more granular config options here if we want to retain the scala 2 syntax for any of the specific changes here.