Skip to content

PIL-2151: Corrected content on BankAccountDetailsView #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevincoatsworth wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PIL-2151: Corrected content on BankAccountDetailsView #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions conf/messages.en
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1259,10 +1259,10 @@ repayments.bankAccountDetails.heading = Bank account details
repayments.bankAccountDetails.hint = The account must be a UK business account.
repayments.bankAccountDetails.bankName = Name of the bank
repayments.bankAccountDetails.accountName = Name on the account
repayments.bankAccountDetails.sortCode = Sort Code
repayments.bankAccountDetails.sortCode.hintText = Must be 6 digits long
repayments.bankAccountDetails.sortCode = Sort code
repayments.bankAccountDetails.sortCode.hintText = Must be 6 digits
repayments.bankAccountDetails.accountNumber = Account number
repayments.bankAccountDetails.accountNumber.hintText = Must be between 6 and 8 digits long
repayments.bankAccountDetails.accountNumber.hintText = Must be 8 digits

repayments.bankAccountDetails.bankError = Enter the name of the bank
repayments.bankAccountDetails.accountError = Enter the name on the account
Expand Down
6 changes: 3 additions & 3 deletions test/views/repayments/BankAccountDetailsViewSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,15 @@ class BankAccountDetailsViewSpec extends ViewSpecBase with StringGenerators {
val labels: Elements = view.getElementsByClass("govuk-label")
labels.get(0).text mustBe "Name of the bank"
labels.get(1).text mustBe "Name on the account"
labels.get(2).text mustBe "Sort Code"
labels.get(2).text mustBe "Sort code"
labels.get(3).text mustBe "Account number"
}

"have the correct hints" in {
val hints: Elements = view.getElementsByClass("govuk-hint")
hints.get(0).text mustBe "The account must be a UK business account."
hints.get(1).text mustBe "Must be 6 digits long"
hints.get(2).text mustBe "Must be between 6 and 8 digits long"
hints.get(1).text mustBe "Must be 6 digits"
hints.get(2).text mustBe "Must be 8 digits"
}

"have a button" in {
Expand Down