fixed PSScriptAnalyzer rule which requires the process block

hmmwhatsthisdo · Jun 13, 2024 · 556fe4b · 556fe4b
1 parent ca290a6
commit 556fe4b
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 24 deletions.
diff --git a/JiraPS/Private/Resolve-JiraIssueObject.ps1 b/JiraPS/Private/Resolve-JiraIssueObject.ps1
@@ -33,19 +33,21 @@ function Resolve-JiraIssueObject {
         $Credential = [System.Management.Automation.PSCredential]::Empty
     )
 
-    # As we are not able to use proper type casting in the parameters, this is a workaround
-    # to extract the data from a JiraPS.Issue object
-    # This shall be removed once we have custom classes for the module
-    if ("JiraPS.Issue" -in $InputObject.PSObject.TypeNames -and $InputObject.RestURL) {
-        Write-DebugMessage "[$($MyInvocation.MyCommand.Name)] Using `$InputObject as object"
-        return $InputObject
-    }
-    elseif ("JiraPS.Issue" -in $InputObject.PSObject.TypeNames -and $InputObject.Key) {
-        Write-DebugMessage "[$($MyInvocation.MyCommand.Name)] Resolve Issue to object"
-        return (Get-JiraIssue -Key $InputObject.Key -Credential $Credential -ErrorAction Stop)
-    }
-    else {
-        Write-DebugMessage "[$($MyInvocation.MyCommand.Name)] Resolve Issue to object"
-        return (Get-JiraIssue -Key $InputObject.ToString() -Credential $Credential -ErrorAction Stop)
+    process {
+        # As we are not able to use proper type casting in the parameters, this is a workaround
+        # to extract the data from a JiraPS.Issue object
+        # This shall be removed once we have custom classes for the module
+        if ("JiraPS.Issue" -in $InputObject.PSObject.TypeNames -and $InputObject.RestURL) {
+            Write-DebugMessage "[$($MyInvocation.MyCommand.Name)] Using `$InputObject as object"
+            return $InputObject
+        }
+        elseif ("JiraPS.Issue" -in $InputObject.PSObject.TypeNames -and $InputObject.Key) {
+            Write-DebugMessage "[$($MyInvocation.MyCommand.Name)] Resolve Issue to object"
+            return (Get-JiraIssue -Key $InputObject.Key -Credential $Credential -ErrorAction Stop)
+        }
+        else {
+            Write-DebugMessage "[$($MyInvocation.MyCommand.Name)] Resolve Issue to object"
+            return (Get-JiraIssue -Key $InputObject.ToString() -Credential $Credential -ErrorAction Stop)
+        }
     }
 }
diff --git a/JiraPS/Private/Resolve-JiraUser.ps1 b/JiraPS/Private/Resolve-JiraUser.ps1
@@ -36,15 +36,17 @@ function Resolve-JiraUser {
         $Credential = [System.Management.Automation.PSCredential]::Empty
     )
 
-    # As we are not able to use proper type casting in the parameters, this is a workaround
-    # to extract the data from a JiraPS.Issue object
-    # This shall be removed once we have custom classes for the module
-    if ("JiraPS.User" -in $InputObject.PSObject.TypeNames) {
-        Write-DebugMessage "[$($MyInvocation.MyCommand.Name)] Using `$InputObject as object"
-        return $InputObject
-    }
-    else {
-        Write-DebugMessage "[$($MyInvocation.MyCommand.Name)] Resolve User to object"
-        return (Get-JiraUser -UserName $InputObject -Exact:$Exact -Credential $Credential -ErrorAction Stop)
+    process {
+        # As we are not able to use proper type casting in the parameters, this is a workaround
+        # to extract the data from a JiraPS.Issue object
+        # This shall be removed once we have custom classes for the module
+        if ("JiraPS.User" -in $InputObject.PSObject.TypeNames) {
+            Write-DebugMessage "[$($MyInvocation.MyCommand.Name)] Using `$InputObject as object"
+            return $InputObject
+        }
+        else {
+            Write-DebugMessage "[$($MyInvocation.MyCommand.Name)] Resolve User to object"
+            return (Get-JiraUser -UserName $InputObject -Exact:$Exact -Credential $Credential -ErrorAction Stop)
+        }
     }
 }