Skip to content

Adding NIC for lab patient report header #11423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 29, 2025
Merged

Adding NIC for lab patient report header #11423

merged 4 commits into from
Mar 29, 2025

Conversation

PasinduW99
Copy link
Collaborator

@PasinduW99 PasinduW99 commented Mar 29, 2025

Summary by CodeRabbit

  • New Features
    • Patient reports now display the National Identity Card (NIC) number alongside existing details, enhancing the information available in the report.

Copy link
Contributor

coderabbitai bot commented Mar 29, 2025

Walkthrough

The changes add a new <h:outputText> element to the common_report.xhtml file. This element conditionally renders the patient’s National Identity Card (NIC) number by checking if the report item is of type 'NicNo', the item type is not 'Label', and the record is not retired. The insertion occurs between two existing elements without affecting the overall control flow or other declared entities.

Changes

File Change Summary
src/.../common_report.xhtml Inserted a new <h:outputText> element to conditionally display the patient’s NIC number based on defined criteria.

Poem

I'm a coding rabbit, hopping with delight,
Adding NIC details shining bright.
A new <h:outputText> joins the crew,
Sneaking in data like morning dew.
With conditions set and style on track,
I nibble carrots and code—no turning back!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 27cc982 and 9a0573b.

📒 Files selected for processing (1)
  • src/main/webapp/resources/ezcomp/common_report.xhtml (1 hunks)
🔇 Additional comments (1)
src/main/webapp/resources/ezcomp/common_report.xhtml (1)

82-82: The NIC rendering element is correctly implemented, but consider privacy implications.

The added code follows the established pattern for rendering patient information, which is good. However, since National ID Numbers are sensitive personal information, ensure this field is only shown in reports where it's absolutely necessary and to authorized personnel.

Consider adding null checks to prevent potential NullPointerExceptions if any object in the property chain is null. A safer implementation would be:

-<h:outputText rendered="#{myCli.ixItemType ne 'Label' and myCli.reportItemType eq 'NicNo' and myCli.retired eq false }"  value="#{cc.attrs.patientReport.patientInvestigation.patient.person.nic}" style="#{myIi.innerCssStyle};" escape="false" ></h:outputText>
+<h:outputText rendered="#{myCli.ixItemType ne 'Label' and myCli.reportItemType eq 'NicNo' and myCli.retired eq false and cc.attrs.patientReport.patientInvestigation.patient.person.nic ne null}"  value="#{cc.attrs.patientReport.patientInvestigation.patient.person.nic}" style="#{myIi.innerCssStyle};" escape="false" ></h:outputText>

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@PasinduW99 PasinduW99 changed the title Stg branch Adding NIC for lab patient report header Mar 29, 2025
@PasinduW99 PasinduW99 merged commit 1213c83 into development Mar 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants