Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove duplication in Makefile #207

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

rachelcarmena
Copy link
Contributor

Hi @hmemcpy !

I'm preparing the files for Kotlin edition and I saw this comment in Makefile:

#remove this awful duplication ASAP

This super tiny pull request is making a proposal for removing that duplication.

The variable definition is not necessary for the copy target so this line could be removed:

copy: suffix = ''

However, I prefer to make things explicit.

You'll see something like:

mv ctfp-reader''.pdf ../out/v1.3.0-2-gf7db7ca/category-theory-for-programmers''.pdf
mv ctfp-print''.pdf ../out/v1.3.0-2-gf7db7ca/category-theory-for-programmers''-print.pdf

or:

mv ctfp-reader'-scala'.pdf ../out/v1.3.0-2-gf7db7ca/category-theory-for-programmers'-scala'.pdf
mv ctfp-print'-scala'.pdf ../out/v1.3.0-2-gf7db7ca/category-theory-for-programmers'-scala'-print.pdf

And the directory content will be the expected one:

$ tree out/v1.3.0-2-gf7db7ca/
out/v1.3.0-2-gf7db7ca/
├── category-theory-for-programmers.pdf
├── category-theory-for-programmers-print.pdf
├── category-theory-for-programmers-scala.pdf
└── category-theory-for-programmers-scala-print.pdf

@rachelcarmena rachelcarmena changed the title Refactor: remove duplication Refactor: remove duplication in Makefile Aug 29, 2019
@hmemcpy
Copy link
Owner

hmemcpy commented Aug 29, 2019

This is awesome, thank you so much! :D

@hmemcpy hmemcpy merged commit 2e472f0 into hmemcpy:master Aug 29, 2019
@rachelcarmena
Copy link
Contributor Author

Thanks to you, Igal! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants