-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix building on recent Java and all build warnings (#119)
- Loading branch information
Showing
22 changed files
with
144 additions
and
166 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,70 +1,70 @@ | ||
<?xml version="1.0"?> | ||
<ruleset name="PMD rule set" | ||
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_2_0_0.xsd"> | ||
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 https://pmd.sourceforge.io/ruleset_2_0_0.xsd"> | ||
|
||
<description>HMCTS PMD rule set</description> | ||
|
||
<rule ref="category/java/bestpractices.xml"> | ||
<exclude name="GuardLogStatement" /> | ||
<exclude name="JUnitTestContainsTooManyAsserts" /> | ||
<exclude name="GuardLogStatement"/> | ||
<exclude name="JUnitTestContainsTooManyAsserts"/> | ||
</rule> | ||
<rule ref="category/java/codestyle.xml"> | ||
<exclude name="AtLeastOneConstructor" /> | ||
<exclude name="LocalVariableCouldBeFinal" /> | ||
<exclude name="LongVariable" /> | ||
<exclude name="MethodArgumentCouldBeFinal" /> | ||
<exclude name="OnlyOneReturn" /> | ||
<exclude name="TooManyStaticImports" /> | ||
<exclude name="AtLeastOneConstructor"/> | ||
<exclude name="LocalVariableCouldBeFinal"/> | ||
<exclude name="LongVariable"/> | ||
<exclude name="MethodArgumentCouldBeFinal"/> | ||
<exclude name="OnlyOneReturn"/> | ||
<exclude name="TooManyStaticImports"/> | ||
<exclude name="DefaultPackage"/> | ||
<exclude name="CommentDefaultAccessModifier"/> | ||
</rule> | ||
<rule ref="category/java/codestyle.xml/ClassNamingConventions"> | ||
<properties> | ||
<!-- same as any other class --> | ||
<property name="utilityClassPattern" value="[A-Z][a-zA-Z]+" /> | ||
<property name="utilityClassPattern" value="[A-Z][a-zA-Z]+"/> | ||
</properties> | ||
</rule> | ||
<rule ref="category/java/codestyle.xml/MethodNamingConventions"> | ||
<properties> | ||
<property name="junit4TestPattern" value="[a-z][a-zA-Z0-9_]+" /> | ||
<property name="junit4TestPattern" value="[a-z][a-zA-Z0-9_]+"/> | ||
</properties> | ||
</rule> | ||
<rule ref="category/java/codestyle.xml/ShortVariable"> | ||
<properties> | ||
<property name="minimum" value="2" /> | ||
<property name="minimum" value="2"/> | ||
</properties> | ||
</rule> | ||
<rule ref="category/java/design.xml"> | ||
<exclude name="AvoidCatchingGenericException" /> | ||
<exclude name="UseUtilityClass" /> | ||
<exclude name="LoosePackageCoupling" /> | ||
<exclude name="DataClass" /> | ||
<exclude name="AvoidCatchingGenericException"/> | ||
<exclude name="UseUtilityClass"/> | ||
<exclude name="LoosePackageCoupling"/> | ||
<exclude name="DataClass"/> | ||
</rule> | ||
<rule ref="category/java/design.xml/ExcessiveImports"> | ||
<properties> | ||
<property name="minimum" value="35" /><!-- should be reduced --> | ||
<property name="minimum" value="40"/><!-- should be reduced --> | ||
</properties> | ||
</rule> | ||
<rule ref="category/java/design.xml/LawOfDemeter"> | ||
<properties> | ||
<property name="violationSuppressRegex" value="(.*method chain calls.*|.*object not created locally.*)" /> | ||
<property name="violationSuppressRegex" value="(.*method chain calls.*|.*object not created locally.*)"/> | ||
</properties> | ||
</rule> | ||
<rule ref="category/java/design.xml/SignatureDeclareThrowsException"> | ||
<properties> | ||
<property name="IgnoreJUnitCompletely" value="true" /> | ||
<property name="IgnoreJUnitCompletely" value="true"/> | ||
</properties> | ||
</rule> | ||
<rule ref="category/java/documentation.xml"> | ||
<exclude name="CommentRequired" /> | ||
<exclude name="CommentSize" /> | ||
<exclude name="UncommentedEmptyMethodBody" /> | ||
<exclude name="CommentRequired"/> | ||
<exclude name="CommentSize"/> | ||
<exclude name="UncommentedEmptyMethodBody"/> | ||
</rule> | ||
<rule ref="category/java/errorprone.xml"> | ||
<exclude name="BeanMembersShouldSerialize" /> | ||
</rule> | ||
<rule ref="category/java/multithreading.xml" /> | ||
<rule ref="category/java/performance.xml" /> | ||
<rule ref="category/java/security.xml" /> | ||
<rule ref="category/java/errorprone.xml" /> | ||
<rule ref="category/java/multithreading.xml"/> | ||
<rule ref="category/java/performance.xml"/> | ||
<rule ref="category/java/security.xml"/> | ||
|
||
</ruleset> | ||
</ruleset> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.