Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any valid email apart from cjsm.net #842

Merged
merged 1 commit into from
May 23, 2024

Conversation

jasonpaige
Copy link
Contributor

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/S28-2994

Change description

This is to be left on demo for now in order for QA and the business to complete testing

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

Copy link
Contributor

Plan Result (stg)

No changes. Your infrastructure matches the configuration.

Copy link
Contributor

Plan Result (prod)

Plan: 0 to add, 9 to change, 0 to destroy.
  • Update
    • azurerm_monitor_action_group.pre-support[0]
    • azurerm_monitor_metric_alert.postgres_alert_active_connections[0]
    • azurerm_monitor_metric_alert.postgres_alert_cpu[0]
    • azurerm_monitor_metric_alert.postgres_alert_failed_connections[0]
    • azurerm_monitor_metric_alert.postgres_alert_memory[0]
    • azurerm_monitor_metric_alert.postgres_alert_storage_utilization[0]
    • azurerm_monitor_metric_alert.storage_final_alert_capacity[0]
    • azurerm_monitor_metric_alert.storage_ingest_alert_capacity[0]
    • module.backup_vault[0].azurerm_data_protection_backup_vault.this
Change Result (Click me)
  # azurerm_monitor_action_group.pre-support[0] will be updated in-place
  ~ resource "azurerm_monitor_action_group" "pre-support" {
        id                  = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Insights/actionGroups/CriticalAlertsAction"
        name                = "CriticalAlertsAction"
      ~ tags                = {
          - "application"  = "pre-recorded-evidence" -> null
          - "builtFrom"    = "https://github.com/HMCTS/pre-network.git" -> null
          - "businessArea" = "Cross-Cutting" -> null
          - "environment"  = "production" -> null
        }
        # (4 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # azurerm_monitor_metric_alert.postgres_alert_active_connections[0] will be updated in-place
  ~ resource "azurerm_monitor_metric_alert" "postgres_alert_active_connections" {
        id                       = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Insights/metricAlerts/postgres_active_connections_greater_than_80_percent"
        name                     = "postgres_active_connections_greater_than_80_percent"
      ~ tags                     = {
          - "application"  = "pre-recorded-evidence" -> null
          - "builtFrom"    = "https://github.com/HMCTS/pre-network.git" -> null
          - "businessArea" = "Cross-Cutting" -> null
          - "environment"  = "production" -> null
        }
        # (10 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # azurerm_monitor_metric_alert.postgres_alert_cpu[0] will be updated in-place
  ~ resource "azurerm_monitor_metric_alert" "postgres_alert_cpu" {
        id                       = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Insights/metricAlerts/postgres_cpu_percent_95"
        name                     = "postgres_cpu_percent_95"
      ~ tags                     = {
          - "application"  = "pre-recorded-evidence" -> null
          - "builtFrom"    = "https://github.com/HMCTS/pre-network.git" -> null
          - "businessArea" = "Cross-Cutting" -> null
          - "environment"  = "production" -> null
        }
        # (10 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # azurerm_monitor_metric_alert.postgres_alert_failed_connections[0] will be updated in-place
  ~ resource "azurerm_monitor_metric_alert" "postgres_alert_failed_connections" {
        id                       = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Insights/metricAlerts/postgres_failed_connections_greater_than_10"
        name                     = "postgres_failed_connections_greater_than_10"
      ~ tags                     = {
          - "application"  = "pre-recorded-evidence" -> null
          - "builtFrom"    = "https://github.com/HMCTS/pre-network.git" -> null
          - "businessArea" = "Cross-Cutting" -> null
          - "environment"  = "production" -> null
        }
        # (10 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # azurerm_monitor_metric_alert.postgres_alert_memory[0] will be updated in-place
  ~ resource "azurerm_monitor_metric_alert" "postgres_alert_memory" {
        id                       = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Insights/metricAlerts/postgres_memory_percent_95"
        name                     = "postgres_memory_percent_95"
      ~ tags                     = {
          - "application"  = "pre-recorded-evidence" -> null
          - "builtFrom"    = "https://github.com/HMCTS/pre-network.git" -> null
          - "businessArea" = "Cross-Cutting" -> null
          - "environment"  = "production" -> null
        }
        # (10 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # azurerm_monitor_metric_alert.postgres_alert_storage_utilization[0] will be updated in-place
  ~ resource "azurerm_monitor_metric_alert" "postgres_alert_storage_utilization" {
        id                       = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Insights/metricAlerts/postgres_storage_utilization_90"
        name                     = "postgres_storage_utilization_90"
      ~ tags                     = {
          - "application"  = "pre-recorded-evidence" -> null
          - "builtFrom"    = "https://github.com/HMCTS/pre-network.git" -> null
          - "businessArea" = "Cross-Cutting" -> null
          - "environment"  = "production" -> null
        }
        # (10 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # azurerm_monitor_metric_alert.storage_final_alert_capacity[0] will be updated in-place
  ~ resource "azurerm_monitor_metric_alert" "storage_final_alert_capacity" {
        id                       = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Insights/metricAlerts/used_capacity"
        name                     = "used_capacity"
      ~ tags                     = {
          - "application"  = "pre-recorded-evidence" -> null
          - "builtFrom"    = "https://github.com/HMCTS/pre-network.git" -> null
          - "businessArea" = "Cross-Cutting" -> null
          - "environment"  = "production" -> null
        }
        # (10 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # azurerm_monitor_metric_alert.storage_ingest_alert_capacity[0] will be updated in-place
  ~ resource "azurerm_monitor_metric_alert" "storage_ingest_alert_capacity" {
        id                       = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Insights/metricAlerts/used_capacity"
        name                     = "used_capacity"
      ~ scopes                   = [
          - "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Storage/storageAccounts/prefinalsaprod",
          + "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Storage/storageAccounts/preingestsaprod",
        ]
      ~ tags                     = {
          - "application"  = "pre-recorded-evidence" -> null
          - "builtFrom"    = "https://github.com/HMCTS/pre-network.git" -> null
          - "businessArea" = "Cross-Cutting" -> null
          - "environment"  = "production" -> null
        }
        # (9 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.backup_vault[0].azurerm_data_protection_backup_vault.this will be updated in-place
  ~ resource "azurerm_data_protection_backup_vault" "this" {
        id                         = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.DataProtection/backupVaults/pre-backup-vault-prod"
        name                       = "pre-backup-vault-prod"
      ~ tags                       = {
          - "application"  = "pre-recorded-evidence" -> null
          - "builtFrom"    = "https://github.com/HMCTS/pre-network.git" -> null
          - "businessArea" = "Cross-Cutting" -> null
          - "environment"  = "production" -> null
        }
        # (6 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 9 to change, 0 to destroy.

@jasonpaige jasonpaige force-pushed the S28-2994/b2c-signup-email-validation branch from 94b3115 to 256ec37 Compare May 23, 2024 12:28
@jasonpaige jasonpaige marked this pull request as ready for review May 23, 2024 14:55
@jasonpaige jasonpaige requested a review from zc-hmcts as a code owner May 23, 2024 14:55
@jasonpaige jasonpaige merged commit ad3fa20 into master May 23, 2024
1 check passed
@jasonpaige jasonpaige deleted the S28-2994/b2c-signup-email-validation branch May 23, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants