PUB-2124 - Updated to renovate #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plan Result
Change Result (Click me) # azurerm_resource_group.rg will be updated in-place
~ resource "azurerm_resource_group" "rg" {
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/pip-bootstrap-stg-rg"
name = "pip-bootstrap-stg-rg"
~ tags = {
- "BuiltFrom" = "https://github.com/HMCTS/pip-shared-infrastructure-bootstap.git" -> null
+ "builtFrom" = "https://github.com/HMCTS/pip-shared-infrastructure-bootstap.git"
- "changeUrl" = "" -> null
# (5 unchanged elements hidden)
}
# (1 unchanged attribute hidden)
}
# module.kv.azurerm_key_vault.kv will be updated in-place
~ resource "azurerm_key_vault" "kv" {
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/pip-bootstrap-stg-rg/providers/Microsoft.KeyVault/vaults/pip-bootstrap-stg-kv"
name = "pip-bootstrap-stg-kv"
~ tags = {
- "BuiltFrom" = "https://github.com/HMCTS/pip-shared-infrastructure-bootstap.git" -> null
+ "builtFrom" = "https://github.com/HMCTS/pip-shared-infrastructure-bootstap.git"
- "changeUrl" = "" -> null
# (5 unchanged elements hidden)
}
# (13 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# module.kv.azurerm_key_vault_access_policy.creator_access_policy will be updated in-place
~ resource "azurerm_key_vault_access_policy" "creator_access_policy" {
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/pip-bootstrap-stg-rg/providers/Microsoft.KeyVault/vaults/pip-bootstrap-stg-kv/objectId/7ef3b6ce-3974-41ab-8512-c3ef4bb8ae01"
~ key_permissions = [
# (7 unchanged elements hidden)
"Restore",
+ "Decrypt",
+ "Encrypt",
+ "UnwrapKey",
+ "WrapKey",
+ "Sign",
+ "Verify",
+ "GetRotationPolicy",
]
# (6 unchanged attributes hidden)
}
# module.kv.azurerm_key_vault_access_policy.product_team_access_policy will be updated in-place
~ resource "azurerm_key_vault_access_policy" "product_team_access_policy" {
~ certificate_permissions = [
# (10 unchanged elements hidden)
"DeleteIssuers",
+ "Recover",
]
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/pip-bootstrap-stg-rg/providers/Microsoft.KeyVault/vaults/pip-bootstrap-stg-kv/objectId/7bde62e7-b39f-487c-95c9-b4c794fdbb96"
~ key_permissions = [
# (4 unchanged elements hidden)
"Delete",
+ "Recover",
]
~ secret_permissions = [
# (2 unchanged elements hidden)
"Delete",
+ "Recover",
]
# (4 unchanged attributes hidden)
}
# module.kv.azurerm_monitor_diagnostic_setting.kv-ds will be updated in-place
~ resource "azurerm_monitor_diagnostic_setting" "kv-ds" {
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/pip-bootstrap-stg-rg/providers/Microsoft.KeyVault/vaults/pip-bootstrap-stg-kv|pip-bootstrap-stg-kv"
name = "pip-bootstrap-stg-kv"
# (2 unchanged attributes hidden)
- metric {
- category = "AllMetrics" -> null
- enabled = false -> null
- retention_policy {
- days = 0 -> null
- enabled = false -> null
}
}
# (3 unchanged blocks hidden)
}
Plan: 0 to add, 5 to change, 0 to destroy.ℹ️ Objects have changed outside of TerraformThis feature was introduced from Terraform v0.15.4. Terraform detected the following changes made outside of Terraform since the
last "terraform apply":
# azurerm_resource_group.rg has been changed
~ resource "azurerm_resource_group" "rg" {
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/pip-bootstrap-stg-rg"
name = "pip-bootstrap-stg-rg"
tags = {
"BuiltFrom" = "https://github.com/HMCTS/pip-shared-infrastructure-bootstap.git"
"application" = "publishing-information-service"
"businessArea" = "Cross-Cutting"
"changeUrl" = ""
"contactSlackChannel" = "#publishing-and-information"
"environment" = "staging"
"managedBy" = "Future Hearings - Publishing Information Project"
}
# (1 unchanged attribute hidden)
}
# module.kv.azurerm_monitor_diagnostic_setting.kv-ds has been changed
~ resource "azurerm_monitor_diagnostic_setting" "kv-ds" {
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/pip-bootstrap-stg-rg/providers/Microsoft.KeyVault/vaults/pip-bootstrap-stg-kv|pip-bootstrap-stg-kv"
name = "pip-bootstrap-stg-kv"
# (2 unchanged attributes hidden)
+ enabled_log {
+ category = "AuditEvent"
+ retention_policy {
+ days = 14
+ enabled = true
}
}
+ log {
+ category = "AuditEvent"
+ enabled = true
+ retention_policy {
+ days = 14
+ enabled = true
}
}
- log {
- category = "AuditEvent" -> null
- enabled = true -> null
- retention_policy {
- days = 14 -> null
- enabled = true -> null
}
}
+ log {
+ category = "AzurePolicyEvaluationDetails"
+ enabled = false
+ retention_policy {
+ days = 0
+ enabled = false
}
}
+ metric {
+ category = "AllMetrics"
+ enabled = false
+ retention_policy {
+ days = 0
+ enabled = false
}
}
}
# module.kv.azurerm_key_vault.kv has been changed
~ resource "azurerm_key_vault" "kv" {
~ access_policy = [
# (4 unchanged elements hidden)
{
application_id = ""
certificate_permissions = [
"List",
"Update",
"Create",
"Import",
"Delete",
"ManageContacts",
"ManageIssuers",
"GetIssuers",
"ListIssuers",
"SetIssuers",
"DeleteIssuers",
]
key_permissions = [
"List",
"Update",
"Create",
"Import",
"Delete",
]
object_id = "7bde62e7-b39f-487c-95c9-b4c794fdbb96"
secret_permissions = [
"List",
"Set",
"Delete",
]
storage_permissions = []
tenant_id = "531ff96d-0ae9-462a-8d2d-bec7c0b42082"
},
+ {
+ application_id = ""
+ certificate_permissions = []
+ key_permissions = []
+ object_id = "626041d7-1bf3-46ca-84b6-28b6b0c60efe"
+ secret_permissions = [
+ "List",
+ "Get",
]
+ storage_permissions = []
+ tenant_id = "531ff96d-0ae9-462a-8d2d-bec7c0b42082"
},
]
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/pip-bootstrap-stg-rg/providers/Microsoft.KeyVault/vaults/pip-bootstrap-stg-kv"
name = "pip-bootstrap-stg-kv"
+ public_network_access_enabled = true
tags = {
"BuiltFrom" = "https://github.com/HMCTS/pip-shared-infrastructure-bootstap.git"
"application" = "publishing-information-service"
"businessArea" = "Cross-Cutting"
"changeUrl" = ""
"contactSlackChannel" = "#publishing-and-information"
"environment" = "staging"
"managedBy" = "Future Hearings - Publishing Information Project"
}
# (11 unchanged attributes hidden)
# (1 unchanged block hidden)
}
Unless you have made equivalent changes to your configuration, or ignored the |
KianKwa
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PUB-2144
Change description
Updated pipeline to use renovate
Does this PR introduce a breaking change? (check one with "x")