PUB-2589 - Redesign select list types page #1358
Conversation
…user is already subscribed to that list type
…user is already subscribed to that list type
…Select-List-Types
NatashaAlker
changed the base branch from
master
to
PUB-2588-Add-List-Subscription
| optionsHtml: filterOptionsHtml | ||
| }) }} | ||
| </form> | ||
| </div> | ||
| <div class="layout-width-three-fifths" id="content"> |
There was a problem hiding this comment.
This 'layout-width-three-fifth' div can be removed now since you have removed the 'two-fifth' div?
There was a problem hiding this comment.
Weirdly it messes up the formatting when this div is removed
There was a problem hiding this comment.
That is so weird. The 'layout-width-three-fifth' class is doing opposite of what it should do. In this case, you can replace 'layout-width-three-fifth' with 'govuk-grid-column-full' that should work. The three-fifth class is a bit misleading there.
| selectedListTypes.length == 0 || | ||
| selectedListTypes.includes(listName) | ||
| ) { | ||
| if (selectedListTypes != null && selectedListTypes.includes(listName)) { |
There was a problem hiding this comment.
Don't need the if/else statements here. The following lines can be simplified to:
listType.checked = selectedListTypes?.length && selectedListTypes.includes(listName);
|
JIRA link
https://tools.hmcts.net/jira/browse/PUB-2589
Change description
Redesign of the select list types page in the verified user subscription flow
Does this PR introduce a breaking change? (check one with "x")