-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PUB-2589 - Redesign select list types page #1358
base: PUB-2588-Add-List-Subscription
Are you sure you want to change the base?
PUB-2589 - Redesign select list types page #1358
Conversation
…user is already subscribed to that list type
…user is already subscribed to that list type
…Select-List-Types
optionsHtml: filterOptionsHtml | ||
}) }} | ||
</form> | ||
</div> | ||
<div class="layout-width-three-fifths" id="content"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This 'layout-width-three-fifth' div can be removed now since you have removed the 'two-fifth' div?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is so weird. The 'layout-width-three-fifth' class is doing opposite of what it should do. In this case, you can replace 'layout-width-three-fifth' with 'govuk-grid-column-full' that should work. The three-fifth class is a bit misleading there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed :)
selectedListTypes.length == 0 || | ||
selectedListTypes.includes(listName) | ||
) { | ||
if (selectedListTypes != null && selectedListTypes.includes(listName)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need the if/else statements here. The following lines can be simplified to:
listType.checked = selectedListTypes?.length && selectedListTypes.includes(listName);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed :)
Quality Gate passedIssues Measures |
JIRA link
https://tools.hmcts.net/jira/browse/PUB-2589
Change description
Redesign of the select list types page in the verified user subscription flow
Does this PR introduce a breaking change? (check one with "x")