Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added readme files for components #967

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added readme files for components #967

wants to merge 3 commits into from

Conversation

arnabsubediHMCTS
Copy link

Jira link

See https://tools.hmcts.net/jira/browse/PO-927

Change description

Added readme files for components.

Testing done

No testing required.

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

iamfrankiemoran
iamfrankiemoran requested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@iamfrankiemoran iamfrankiemoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have the alphagov folder under component which contains one more component. But great job!

src/app/components/govuk/govuk-cancel-link/readme.md Outdated Show resolved Hide resolved
src/app/components/govuk/govuk-back-link/readme.md Outdated Show resolved Hide resolved
src/app/components/govuk/govuk-select/readme.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamfrankiemoran iamfrankiemoran iamfrankiemoran approved these changes

@max-holland max-holland Awaiting requested review from max-holland

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
ns:opal prd:opal rel:opal-frontend-pr-967
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnabsubediHMCTS @iamfrankiemoran