NFDIV-4922: Applicant2 address question pages #4444

FaisalMoJ · 2025-11-17T10:35:44Z

Change description

Applicant2 address question pages.

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/NFDIV-4922

Before merging a pull request make sure that:

tests have been updated / new tests has been added (if needed)
README and other documentation has been updated / added (if needed)

If this ticket will have any visible impact on users and is not behind a feature toggle, make sure that:

this ticket been reviewed by QA
the user story been signed off by the PO

Note that bug fixes, dependency updates and technical tasks do not directly impact the user experience and can be merged without QA and PO review.

If this user story cannot be immediately merged find a way to put it behind a feature toggle and get it merged.

adamg-hmcts · 2025-11-19T17:58:18Z

src/main/steps/applicant1/address-finding/content.ts

+  title: 'It’s easier to proceed with a postal address',
+  line1:
+    'It’s usually faster and less expensive if you can provide us with a postal address. If you wish to proceed without an address, you will need to complete and pay for an additional application once you have submitted this one.',
+  line2: `If you cannot find your ${partner}’s address, you may also provide your ${partner}’s:`,
+  solicitorAdderss: 'solicitor’s address, if they have one',
+  workAddress: `work address, if you have your ${partner}’s permission`,
+  line3:
+    'You could also try looking for them on social media, or contacting their friends or relatives if you feel safe doing so.',
+  line4: 'You can save your application here and try to find an address if you need to.',
+  foundTheirAddress: `Have you been able to find your ${partner}’s address?`,
+  errors: {
+    applicant1FoundApplicant2Address: {
+      required,
+    },
+  },
+});


Looks like we might need to add the bullet points from the design and remove formatting. Design:

Frontend:

Ah sorry i will fix this now

src/main/steps/applicant1/address-finding/content.ts

adamg-hmcts · 2025-11-19T18:00:51Z

src/main/steps/applicant1/do-you-have-partner-address/content.ts

+import { Applicant2Represented } from '../../../app/case/definition';
+import { TranslationFn } from '../../../app/controller/GetController';
+import { FormContent } from '../../../app/form/Form';
+import { isFieldFilledIn } from '../../../app/form/validation';
+import { CommonContent } from '../../common/common.content';
+
+const en = ({ isDivorce, partner }: CommonContent) => ({
+  title: `Does your ${partner} have a solicitor representing them?`,
+  line1: `The court only needs to know if your ${partner} has a solicitor who is representing them for
+  ${isDivorce ? 'the divorce' : 'the process to end your civil partnership'}.
+  You do not need to tell the court about a solicitor they use for other purposes.`,
+  yes: 'Yes, they have a solicitor representing them',
+  no: 'No, they do not have a solicitor representing them',
+  notSure: "I'm not sure",
+  errors: {
+    applicant1IsApplicant2Represented: {
+      required: 'You have not answered the question. Select an answer before continuing.',
+    },
+  },
+});


Looks like we may be able to remove this page? I can't see where it's being used

Yes i pushed this change by mistake i will remove that

adamg-hmcts · 2025-11-19T18:03:37Z

src/main/steps/applicant1/how-to-progress-without-an-address/content.ts

@@ -0,0 +1,57 @@
+import config from 'config';


Nit: I don't think the URL path used in the UCD prototype is a very good description for this page. It's currently set as:
"address-what-you-need"

Maybe we could adjust it? Fubara didn't mind when we changed URLs for No Response:
"how-to-progress-without-an-address"

adamg-hmcts · 2025-11-19T18:04:13Z

src/main/steps/applicant1/address-what-you-need/content.ts

+  line2: `You’ll be able to do this once you’ve submitted your ${
+    isDivorce ? 'divorce application' : 'application to end civil partnership'
+  }.`,
+  line3: `This will cost £58, but you may be able to <a class="govuk-link" target="_blank" href="${config.get(


We could make the £58 fee dynamic/load it from fees config

Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com>

adamg-hmcts · 2025-11-21T09:08:01Z

src/main/steps/applicant1Sequence.ts

+      if (data.applicant1IsApplicant2Represented === Applicant2Represented.YES) {
+        return data.applicant1KnowsApplicant2Address === YesOrNo.YES ? ENTER_THEIR_ADDRESS : ADDRESS_FINDING;


Is it right that we only run this logic when the applicant thinks app2 is represented?

It looks as though the else if block below may need to be removed, as the NEED_TO_GET_ADDRESS page doesn't exist anymore in the new journey. We could delete that page and some of the others that are being removed

hmcts-jenkins-j-to-z · 2025-11-25T13:25:39Z

Plan Result (aat)

Plan: 0 to add, 1 to change, 0 to destroy.

Update
- module.nfdiv-frontend-redis6.azurerm_redis_cache.redis

Change Result (Click me)

  # module.nfdiv-frontend-redis6.azurerm_redis_cache.redis will be updated in-place
  ~ resource "azurerm_redis_cache" "redis" {
        id                                 = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/nfdiv-cache-aat/providers/Microsoft.Cache/redis/nfdiv-frontend-aat"
        name                               = "nfdiv-frontend-aat"
        tags                               = {
            "application"         = "no-fault-divorce"
            "autoShutdown"        = "true"
            "builtFrom"           = "https://github.com/HMCTS/nfdiv-frontend.git"
            "businessArea"        = "CFT"
            "contactSlackChannel" = "#no-fault-divorce"
            "environment"         = "staging"
            "managedBy"           = "No Fault Divorce"
        }
        # (24 unchanged attributes hidden)

      ~ redis_configuration {
          ~ maxfragmentationmemory_reserved         = 125 -> 642
          ~ maxmemory_delta                         = 125 -> 642
          ~ maxmemory_reserved                      = 125 -> 642
            # (14 unchanged attributes hidden)
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.

hmcts-jenkins-j-to-z · 2025-11-25T13:26:13Z

Plan Result (prod)

No changes. Your infrastructure matches the configuration.

src/main/app/case/to-api-format.ts

adamg-hmcts · 2025-11-26T11:24:34Z

src/main/steps/applicant1/do-you-have-address/content.ts

+  title: `${
+    isApplicant2Represented ? `Your ${partner}’s postal address` : `Do you have your ${partner}'s postal address?`
+  }`,
+  line1: `${
+    isApplicant2Represented
+      ? `We need your ${partner}’s address so that we can notify them about the ${
+          isDivorce ? 'divorce' : 'application to end civil partnership'
+        } by post.`
+      : hasAContactForPartner
+        ? `The court needs your ${partner}'s address, to notify them by letter about the ${
+            isDivorce ? 'divorce' : 'ending your civil partnership'
+          }.`
+        : `It’s important you provide your ${partner}'s address. You did not provide their email address and the court needs a way to ‘serve’ (deliver) the ${
+            isDivorce ? 'divorce' : 'ending your civil partnership'
+          } papers to them.`
+  }`,


Is this conditional content from Fubara? I had the impression they'll now see the same content regardless of whether applicant 2 is represented

adamg-hmcts · 2025-11-26T11:26:11Z

src/main/steps/applicant1Sequence.ts

+      if (data.applicant1KnowsApplicant2Address === YesOrNo.NO) {
+        return ADDRESS_FINDING;
      } else {
        return ENTER_THEIR_ADDRESS;
      }


Nit: We could make this a ternary expression like the other paths, for consistency and because they're slightly easier to read

Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com>

FaisalMoJ added 4 commits November 17, 2025 10:35

NFDIV-4922: Applicant2 address question pages

b380f86

NFDIV-4922: Fix url issue

1bbd014

NFDIV-4922: move address question after solicitor details

02d01ab

NFDIV-4922: Fix yarn audit issue

cb65938

hmcts-jenkins-j-to-z bot deployed to preview November 17, 2025 17:12 View deployment

hmcts-jenkins-j-to-z bot added ns:nfdiv prd:nfdiv rel:nfdiv-frontend-pr-4444 labels Nov 17, 2025

FaisalMoJ added 2 commits November 19, 2025 14:38

NFDIV-4922: Fix logic around addres

8ef5497

NFDIV-4922: Fix logic around address

b286d48

hmcts-jenkins-j-to-z bot deployed to preview November 19, 2025 14:48 View deployment

NFDIV-4922: Fix conditional for solicitor page

f0b3f35

hmcts-jenkins-j-to-z bot deployed to preview November 19, 2025 14:59 View deployment

adamg-hmcts reviewed Nov 19, 2025

View reviewed changes

src/main/steps/applicant1/address-finding/content.ts Outdated Show resolved Hide resolved

adamg-hmcts reviewed Nov 19, 2025

View reviewed changes

FaisalMoJ and others added 2 commits November 20, 2025 16:13

Update src/main/steps/applicant1/address-finding/content.ts

c82c1fb

Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com>

NFDIV-4922: Fix PR comments

da91d33

hmcts-jenkins-j-to-z bot deployed to preview November 20, 2025 17:05 View deployment

adamg-hmcts reviewed Nov 21, 2025

View reviewed changes

FaisalMoJ added 2 commits November 23, 2025 17:38

NFDIV-4922: Update form nunjuck file

9ddfc04

NFDIV-4922: Adjust address finding logic

db6e5fc

hmcts-jenkins-j-to-z bot deployed to preview November 24, 2025 07:21 View deployment

NFDIV-4922: Revert changes for further action needed

6d49ac9

hmcts-jenkins-j-to-z bot added the aat/add-or-update label Nov 25, 2025

hmcts-jenkins-j-to-z bot added the prod/no-changes label Nov 25, 2025

hmcts-jenkins-j-to-z bot deployed to preview November 25, 2025 13:26 View deployment

FaisalMoJ added 2 commits November 25, 2025 14:03

NFDIV-4922: Revert further action needed nunjuck changes

e277413

NFDIV-4922: Remove unwanted changes

6aa5a7e

hmcts-jenkins-j-to-z bot deployed to preview November 25, 2025 14:15 View deployment

hmcts-jenkins-j-to-z bot deployed to preview November 25, 2025 14:20 View deployment

NFDIV-4922: Set applicant1 knows address if found address

a0d27dc

hmcts-jenkins-j-to-z bot deployed to preview November 26, 2025 09:00 View deployment

adamg-hmcts reviewed Nov 26, 2025

View reviewed changes

Apply suggestion from @adamg-hmcts

9ffa101

Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com>

hmcts-jenkins-j-to-z bot deployed to preview November 26, 2025 11:50 View deployment

		if (data.applicant1IsApplicant2Represented === Applicant2Represented.YES) {
		return data.applicant1KnowsApplicant2Address === YesOrNo.YES ? ENTER_THEIR_ADDRESS : ADDRESS_FINDING;

NFDIV-4922: Applicant2 address question pages #4444

Are you sure you want to change the base?

NFDIV-4922: Applicant2 address question pages #4444

Uh oh!

Conversation

FaisalMoJ commented Nov 17, 2025

Change description

JIRA link (if applicable)

If this user story cannot be immediately merged find a way to put it behind a feature toggle and get it merged.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hmcts-jenkins-j-to-z bot commented Nov 25, 2025

Plan Result (aat)

Uh oh!

hmcts-jenkins-j-to-z bot commented Nov 25, 2025

Plan Result (prod)

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants