DFPL-1462 Tidy up upload and create orders to prevent incorrect MI #5375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ccd configuration
Plan Result (aat)
Change Result (Click me) # azurerm_key_vault_secret.update-summary-tab-cron will be updated in-place
~ resource "azurerm_key_vault_secret" "update-summary-tab-cron" {
id = "https://fpl-aat.vault.azure.net/secrets/update-summary-tab-cron/610e9d1fb33f446c9b8ee86a6a49b90b"
name = "update-summary-tab-cron"
- not_before_date = "2023-11-22T08:32:40Z" -> null
tags = {}
# (7 unchanged attributes hidden)
}
# module.fpl-action-group.azurerm_resource_group_template_deployment.action-group will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "action-group" {
id = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/fpl-case-service-aat/providers/Microsoft.Resources/deployments/fpl-support"
name = "fpl-support"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ emailReceiverAddress = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ emailReceiverName = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ shortName = {
~ type = "String" -> "string"
}
}
# (3 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy. |
Plan Result (prod)
Change Result (Click me) # module.fpl-action-group.azurerm_resource_group_template_deployment.action-group will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "action-group" {
id = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-support"
name = "fpl-support"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ emailReceiverAddress = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ emailReceiverName = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ shortName = {
~ type = "String" -> "string"
}
}
# (3 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
# module.fpl-exceptions-alert.azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
id = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-exceptions"
name = "fpl-exceptions"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ actionGroupRg = {
~ type = "String" -> "string"
}
~ alertDesc = {
~ type = "String" -> "string"
}
~ alertName = {
~ type = "String" -> "string"
}
~ appInsightsName = {
~ type = "String" -> "string"
}
~ appInsightsQuery = {
~ type = "String" -> "string"
}
~ commonTags = {
~ type = "String" -> "string"
}
~ customEmailSubject = {
~ type = "String" -> "string"
}
~ frequencyInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
}
~ severityLevel = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ timeWindowInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ triggerThreshold = {
~ type = "String" -> "string"
}
~ triggerThresholdOperator = {
~ type = "String" -> "string"
# (2 unchanged attributes hidden)
}
}
# (4 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
# module.fpl-health-failure-alert.azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
id = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-health-failure"
name = "fpl-health-failure"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ actionGroupRg = {
~ type = "String" -> "string"
}
~ alertDesc = {
~ type = "String" -> "string"
}
~ alertName = {
~ type = "String" -> "string"
}
~ appInsightsName = {
~ type = "String" -> "string"
}
~ appInsightsQuery = {
~ type = "String" -> "string"
}
~ commonTags = {
~ type = "String" -> "string"
}
~ customEmailSubject = {
~ type = "String" -> "string"
}
~ frequencyInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
}
~ severityLevel = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ timeWindowInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ triggerThreshold = {
~ type = "String" -> "string"
}
~ triggerThresholdOperator = {
~ type = "String" -> "string"
# (2 unchanged attributes hidden)
}
}
# (4 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
# module.fpl-performance-alert.azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
id = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-performance"
name = "fpl-performance"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ actionGroupRg = {
~ type = "String" -> "string"
}
~ alertDesc = {
~ type = "String" -> "string"
}
~ alertName = {
~ type = "String" -> "string"
}
~ appInsightsName = {
~ type = "String" -> "string"
}
~ appInsightsQuery = {
~ type = "String" -> "string"
}
~ commonTags = {
~ type = "String" -> "string"
}
~ customEmailSubject = {
~ type = "String" -> "string"
}
~ frequencyInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
}
~ severityLevel = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ timeWindowInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ triggerThreshold = {
~ type = "String" -> "string"
}
~ triggerThresholdOperator = {
~ type = "String" -> "string"
# (2 unchanged attributes hidden)
}
}
# (4 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
# module.fpl-summary-tab-job-alert.azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
id = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-summary-tab-job-failure"
name = "fpl-summary-tab-job-failure"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ actionGroupRg = {
~ type = "String" -> "string"
}
~ alertDesc = {
~ type = "String" -> "string"
}
~ alertName = {
~ type = "String" -> "string"
}
~ appInsightsName = {
~ type = "String" -> "string"
}
~ appInsightsQuery = {
~ type = "String" -> "string"
}
~ commonTags = {
~ type = "String" -> "string"
}
~ customEmailSubject = {
~ type = "String" -> "string"
}
~ frequencyInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
}
~ severityLevel = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ timeWindowInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ triggerThreshold = {
~ type = "String" -> "string"
}
~ triggerThresholdOperator = {
~ type = "String" -> "string"
# (2 unchanged attributes hidden)
}
}
# (4 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
# module.fpl-upcoming-hearings-job-alert.azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
id = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-upcoming-hearings-job-failure"
name = "fpl-upcoming-hearings-job-failure"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ actionGroupRg = {
~ type = "String" -> "string"
}
~ alertDesc = {
~ type = "String" -> "string"
}
~ alertName = {
~ type = "String" -> "string"
}
~ appInsightsName = {
~ type = "String" -> "string"
}
~ appInsightsQuery = {
~ type = "String" -> "string"
}
~ commonTags = {
~ type = "String" -> "string"
}
~ customEmailSubject = {
~ type = "String" -> "string"
}
~ frequencyInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
}
~ severityLevel = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ timeWindowInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ triggerThreshold = {
~ type = "String" -> "string"
}
~ triggerThresholdOperator = {
~ type = "String" -> "string"
# (2 unchanged attributes hidden)
}
}
# (4 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
Plan: 0 to add, 6 to change, 0 to destroy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DFPL-1462
Change description
DFPL-1462 Tidy up upload and create orders to prevent incorrect MI
On upload orders - on the other order, remove the questions 1) Is this a final order 2) Do you want to close the case
Remove do you want to close the case as they are not appropriate & are recording final decisions incorrectly. 4 orders to be be deleted off the upload orders page - 1) Education supervision order (C37) 2) Leave to change surname (C44a) 3) Recovery of a child (C29) 4) Variation/extension of education supervision order (C36)
On create orders - change the name on variation/extension of supervision order to include the word education = Variation/extension of education supervision order (C36)
Does this PR introduce a breaking change? (check one with "x")