DFPL-2289 WIP fixing linting issues

package.json

@@ -1,7 +1,7 @@
 {
   "name": "fpl-ccd-configuration",
   "version": "1.0.0",
-  "type": "module",
+
   "description": "FPL CCD e2e tests",
   "engines": {
     "node": ">=18.0.0"

playwright-e2e/pages/additional-applications.ts

@@ -68,7 +68,7 @@ export class AdditionalApplications extends BasePage {
   }
 
   public async expectAllUploadsCompleted() {
-    let locs = await this.page.getByText('Cancel upload').all();
+    const locs = await this.page.getByText('Cancel upload').all();
     for (let i = 0; i < locs.length; i++) {
       await expect(locs[i]).toBeDisabled();
     }

playwright-e2e/pages/allocation-proposal.ts

@@ -1,4 +1,4 @@
-import { type Page, type Locator, expect } from "@playwright/test";
+import { type Page, type Locator } from "@playwright/test";
 
 export class AllocationProposal {
 

playwright-e2e/pages/applicant-details.ts

@@ -1,4 +1,4 @@
-import { type Page, type Locator, expect } from "@playwright/test";
+import { type Page, type Locator } from "@playwright/test";
 import { BasePage } from "./base-page";
 
 export class ApplicantDetails extends BasePage{

playwright-e2e/pages/base-page.ts

@@ -44,7 +44,7 @@ export class BasePage {
   }
 
   async waitForAllUploadsToBeCompleted() {
-    let locs = await this.page.getByText('Cancel upload').all();
+    const locs = await this.page.getByText('Cancel upload').all();
     for (let i = 0; i < locs.length; i++) {
       await expect(locs[i]).toBeDisabled();
     }
@@ -60,7 +60,7 @@ export class BasePage {
     expect(await this.reloadAndCheckForText(userName, 10000, 3)).toBeTruthy();
   }
 
-  async reloadAndCheckForText(text: string, timeout?: number, maxAttempts?: number): Promise<Boolean> {
+  async reloadAndCheckForText(text: string, timeout?: number, maxAttempts?: number): Promise<boolean> {
     // reload the page, wait 5s, see if it's there
     for (let attempt = 0; attempt < (maxAttempts ?? 12); attempt++) {
       await this.page.reload();

playwright-e2e/pages/create-case.ts

@@ -8,7 +8,7 @@ export class CreateCase {
   readonly createCaseLink: Locator;
   readonly addApplicationTitle: Locator;
   readonly viewHistory: Locator;
-  generatedCaseName: any;
+  generatedCaseName: String;
 
   public constructor(page: Page) {
     this.page = page;
@@ -40,7 +40,7 @@ export class CreateCase {
   }
 
    caseName()  {
-    let formattedDate = CreateCaseName.getFormattedDate();
+    const formattedDate = CreateCaseName.getFormattedDate();
     this.generatedCaseName = `Smoke Test ${formattedDate}`;
   }
 

playwright-e2e/pages/gatekeeping-listing.ts

@@ -1,6 +1,5 @@
 import {BasePage} from "./base-page";
 import {expect, Page} from "@playwright/test";
-import {ManageHearings} from "./manage-hearings";
 import {HearingDetailsMixin} from "./mixins/hearing-details-mixin";
 
 export class GatekeepingListing extends HearingDetailsMixin(BasePage)

playwright-e2e/pages/international-element.ts

@@ -1,4 +1,4 @@
-import { type Page, type Locator, expect } from "@playwright/test";
+import { type Page, type Locator } from "@playwright/test";
 import { BasePage } from "./base-page";
 
 export class InternationalElement extends BasePage {

playwright-e2e/pages/manage-hearings.ts

@@ -1,4 +1,4 @@
-import {type Page, type Locator, expect} from "@playwright/test";
+import {type Page, type Locator } from "@playwright/test";
 import {BasePage} from "./base-page";
 import {HearingDetailsMixin} from "./mixins/hearing-details-mixin";
 

playwright-e2e/pages/respondent-details.ts

@@ -1,4 +1,4 @@
-import { type Page, type Locator, expect } from "@playwright/test";
+import { type Page, type Locator } from "@playwright/test";
 
 export class RespondentDetails {
 

playwright-e2e/pages/welsh-lang-requirements.ts

@@ -1,4 +1,4 @@
-import { type Page, type Locator, expect } from "@playwright/test";
+import { type Page, type Locator } from "@playwright/test";
 import { BasePage } from "./base-page";
 
 export class WelshLangRequirements extends BasePage {

playwright-e2e/settings/test-docs/config.ts

@@ -1,21 +1,25 @@
-import path from "path";
+import { fileURLToPath } from 'url';
+import { dirname, join } from 'path';
 
-export interface testFiles {}
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = dirname(__filename);
+
+interface testFiles {}
 
 interface Config {
   [key: string]: testFiles | string;
 }
 
 const config: Config = {
-  testPdfFile: path.resolve(
+  testPdfFile: join(
     __dirname,
     "../test-docs/testPdf.pdf",
   ),
-  testWordFile: path.resolve(
+  testWordFile: join(
     __dirname,
     "../test-docs/testWordDoc.docx",
   ),
-  testTextFile: path.resolve(
+  testTextFile: join(
     __dirname,
     "../test-docs/testTextFile.txt",
   ),

playwright-e2e/tests/additional-applications.spec.ts

@@ -1,12 +1,12 @@
 import { test } from '../fixtures/create-fixture';
 import { Apihelp } from '../utils/api-helper';
-import caseData from '../caseData/mandatorySubmissionFieldsWithoutAdditionalApp.json';
+import { caseData } from '../caseData/mandatorySubmissionFieldsWithoutAdditionalApp.json';
 import { newSwanseaLocalAuthorityUserOne, judgeWalesUser } from '../settings/user-credentials';
 import { expect } from "@playwright/test";
 import { testConfig } from '../settings/test-config';
 
 test.describe('Upload additional applications', () => {
-  let apiDataSetup = new Apihelp();
+  const apiDataSetup = new Apihelp();
   const dateTime = new Date().toISOString();
   let caseNumber: string;
   let casename: string;

playwright-e2e/tests/judicial-message.spec.ts

@@ -1,15 +1,14 @@
 import { test} from '../fixtures/create-fixture';
-import {Apihelp} from '../utils/api-helper';
-//import {urlConfig} from "../settings/urls";
-import caseData from '../caseData/mandatorySubmissionFields.json';
-import caseDataJudgeMessage from '../caseData/caseWithJudgeMessage.json';
-import caseDataCloseMessage from '../caseData/caseWithJudicialMessageReply.json';
+import { Apihelp } from '../utils/api-helper';
+import * as caseData from '../caseData/mandatorySubmissionFields.json' assert { type: 'json' };
+import * as caseDataJudgeMessage from '../caseData/caseWithJudgeMessage.json' assert { type: 'json' };
+import * as caseDataCloseMessage from '../caseData/caseWithJudicialMessageReply.json' assert { type: 'json' };
 import { newSwanseaLocalAuthorityUserOne,CTSCUser ,judgeUser} from '../settings/user-credentials';
 import { expect } from '@playwright/test';
 
 
 test.describe('send and reply message',()=>{
-  let apiDataSetup = new Apihelp();
+  const apiDataSetup = new Apihelp();
   const dateTime = new Date().toISOString();
   let caseNumber : string;
   let casename : string;

playwright-e2e/tests/manage-documents.spec.ts

@@ -2,11 +2,11 @@ import { test } from '../fixtures/create-fixture';
 import { testConfig } from '../settings/test-config';
 import { CTSCUser, newSwanseaLocalAuthorityUserOne } from '../settings/user-credentials';
 import { Apihelp } from '../utils/api-helper';
-import caseData from '../caseData/mandatorySubmissionFields.json';
+import * as caseData from '../caseData/mandatorySubmissionFields.json' assert { type: 'json' };
 import { expect } from '@playwright/test';
 
 test.describe('Manage Documents', () => {
-    let apiDataSetup = new Apihelp();
+    const apiDataSetup = new Apihelp();
     const dateTime = new Date().toISOString();
     let caseNumber: string;
     let casename: string;

playwright-e2e/tests/manage-hearings.spec.ts

@@ -1,8 +1,8 @@
 import { test } from  '../fixtures/create-fixture';
 import {Apihelp} from '../utils/api-helper';
-import caseData from '../caseData/caseWithHearingDetails.json';
-import vacatedHearingCaseData from '../caseData/caseWithVacatedHearing.json';
-import preJudgeAllocationCaseData from '../caseData/casePreAllocationDecision.json';
+import * as caseData from '../caseData/caseWithHearingDetails.json' assert { type: 'json' };
+import * as vacatedHearingCaseData from '../caseData/caseWithVacatedHearing.json' assert { type: 'json' };
+import * as preJudgeAllocationCaseData from '../caseData/casePreAllocationDecision.json' assert { type: 'json' };
 import {
   CTSCUser,
   newSwanseaLocalAuthorityUserOne,
@@ -12,7 +12,7 @@ import {expect} from "@playwright/test";
 import {testConfig} from "../settings/test-config";
 
 test.describe('manage hearings', () => {
-  let apiDataSetup = new Apihelp();
+  const  apiDataSetup = new Apihelp();
   const dateTime = new Date().toISOString();
   let caseNumber : string;
   let caseName : string;

playwright-e2e/tests/smoke-test.spec.ts

@@ -1,5 +1,4 @@
 import { test, expect } from "../fixtures/fixtures";
-import { BasePage } from "../pages/base-page";
 import { newSwanseaLocalAuthorityUserOne } from "../settings/user-credentials";
 
 test("Smoke Test @smoke-test @accessibility", async ({
@@ -18,11 +17,9 @@ test("Smoke Test @smoke-test @accessibility", async ({
   childDetails,
   welshLangRequirements,
   internationalElement,
-page,
   makeAxeBuilder
 },testInfo) => {
 
-  const basePage = new BasePage(page);
   // 1. Sign in as local-authority user
   await signInPage.visit();
   await signInPage.login(

playwright-e2e/tests/upload-draft-orders.spec.ts

@@ -1,11 +1,11 @@
 import { test } from '../fixtures/create-fixture';
 import { newSwanseaLocalAuthorityUserOne } from '../settings/user-credentials';
 import { Apihelp } from '../utils/api-helper';
-import caseData from '../caseData/caseWithHearingDetails.json';
+import * as caseData from '../caseData/caseWithHearingDetails.json' assert { type: 'json' };
 import { expect } from '@playwright/test';
 
 test.describe('Upload draft orders', () => {
-    let apiDataSetup = new Apihelp();
+    const apiDataSetup = new Apihelp();
     const dateTime = new Date().toISOString();
     let caseNumber: string;
     let casename: string;