Upgrade Gradle with plugins + service dependencies #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamianDunajski
commented
Oct 1, 2019
| @@ -234,7 +234,6 @@ | |||
| <property name="allowMissingParamTags" value="true"/> | |||
| <property name="allowMissingThrowsTags" value="true"/> | |||
| <property name="allowMissingReturnTag" value="true"/> | |||
| <property name="minLineCount" value="2"/> | |||
There was a problem hiding this comment.
Deprecated property got removed in latest version.
akomisarek
reviewed
Oct 1, 2019
| @@ -177,7 +177,7 @@ repositories { | |||
| // it is important to specify logback classic and core packages explicitly as libraries like spring boot | |||
| // enforces it's own (older) version which is not recommended. | |||
| def versions = [ | |||
| reformLogging: '5.0.1', | |||
| reformLogging: '5.1.0', | |||
There was a problem hiding this comment.
I think thanks for that change, we can now remove the netty.io exclusion which I have added in the owasp config.
This reverts commit 5077263.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
None
Change description
As per title...
Does this PR introduce a breaking change? (check one with "x")