Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFPL-1414: Fix issue of Bulk Print receiving duplicated requests #4391

Merged
merged 10 commits into from
May 23, 2023
Merged

DFPL-1414: Fix issue of Bulk Print receiving duplicated requests #4391

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fa17e84
DFPL-1414: Fix issue of Bulk Print receiving duplicated requests
qasimnawaz-moj May 9, 2023
10d9a7e
Send array of recipient names
qasimnawaz-moj May 9, 2023
4108dd0
Send one recipient name per request
qasimnawaz-moj May 9, 2023
8e5438b
Merge branch 'master' into DFPL-1414
Braimah101 May 12, 2023
0eed3d6
Merge branch 'master' into DFPL-1414
qasimnawaz-moj May 12, 2023
8d1a1f8
Fix tests
qasimnawaz-moj May 15, 2023
26ccb90
Fix checkstyle
qasimnawaz-moj May 16, 2023
ad10bb6
Fix more tests
qasimnawaz-moj May 16, 2023
d8f85b5
Merge branch 'master' into DFPL-1414
qasimnawaz-moj May 16, 2023
a482648
Merge branch 'master' into DFPL-1414
qasimnawaz-moj May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion service/src/main/java/uk/gov/hmcts/reform/fpl/service/SendLetterService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,10 @@ public List<SentDocument> send(DocumentReference mainDocument, List<Recipient> r
SendLetterResponse response = sendLetterApi.sendLetter(authTokenGenerator.generate(),
new LetterWithPdfsRequest(List.of(coverDocumentEncoded, mainDocumentEncoded),
SEND_LETTER_TYPE,
Map.of("caseId", caseId, "documentName", mainDocument.getFilename())));
Map.of(
"caseId", caseId,
"documentName", mainDocument.getFilename(),
"recipients", recipients)));
letterId = Optional.ofNullable(response).map(r -> r.letterId.toString()).orElse(EMPTY);

sentDocuments.add(SentDocument.builder()
Expand Down