DMP-3482: Show Automated Job Batch Size in Admin Portal (#1578)

hmcts · Oct 25, 2024 · 8784bad · 8784bad
1 parent 0617a4b
commit 8784bad
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 0 deletions.
diff --git a/cypress/e2e/functional/admin-portal/automated-tasks-spec.cy.js b/cypress/e2e/functional/admin-portal/automated-tasks-spec.cy.js
@@ -72,6 +72,9 @@ describe('Admin - Automated tasks screen', () => {
       cy.get('app-details-table dt').contains('Cron editable');
       cy.get('app-details-table dd').contains('Yes');
 
+      cy.get('app-details-table dt').contains('Batch size');
+      cy.get('app-details-table dd').contains('1000');
+
       cy.get('app-details-table dt').contains('Date created');
       cy.get('app-details-table dd').contains('Mon 1 Jan 2024 at 00:00:00');
 

diff --git a/darts-api-stub/admin/automated-tasks/automated-tasks.js b/darts-api-stub/admin/automated-tasks/automated-tasks.js
@@ -9,6 +9,7 @@ const defaultAutomatedTasks = [
     description: 'Simulate 202 success',
     cron_expression: '0 0 1 * * *',
     is_cron_editable: true,
+    batch_size: 1000,
     is_active: true,
     created_at: '2024-01-01T00:00:00Z',
     created_by: 1,
@@ -21,6 +22,7 @@ const defaultAutomatedTasks = [
     description: 'Simulate 404 not found',
     cron_expression: '0 0 2 * * *',
     is_cron_editable: true,
+    batch_size: 500,
     is_active: false,
     created_at: '2024-01-02T00:00:00Z',
     created_by: 2,
@@ -33,6 +35,7 @@ const defaultAutomatedTasks = [
     description: 'Simulate 409 already running task',
     cron_expression: '0 0 3 * * *',
     is_cron_editable: true,
+    batch_size: 250,
     is_active: true,
     created_at: '2024-01-03T00:00:00Z',
     created_by: 3,

diff --git a/...in/components/automated-tasks/view-automated-tasks/view-automated-tasks.component.spec.ts b/...in/components/automated-tasks/view-automated-tasks/view-automated-tasks.component.spec.ts
@@ -17,6 +17,7 @@ const task: AutomatedTaskDetails = {
   description: 'Task 1 description',
   cronExpression: '1 0 0 * * *',
   isCronEditable: true,
+  batchSize: 1000,
   createdAt: DateTime.fromISO('2021-01-01T00:00:00Z'),
   createdBy: 1,
   lastModifiedAt: DateTime.fromISO('2021-01-01T00:00:00Z'),
@@ -67,6 +68,7 @@ describe('ViewAutomatedTasksComponent', () => {
         Description: 'Task 1 description',
         'Cron expression': '1 0 0 * * *',
         'Cron editable': 'Yes',
+        'Batch size': 1000,
         'Date created': 'Fri 1 Jan 2021 at 00:00:00',
         'Created by': 'User 1',
         'Date modified': 'Fri 1 Jan 2021 at 00:00:00',

diff --git a/...p/admin/components/automated-tasks/view-automated-tasks/view-automated-tasks.component.ts b/...p/admin/components/automated-tasks/view-automated-tasks/view-automated-tasks.component.ts
@@ -51,6 +51,7 @@ export class ViewAutomatedTasksComponent {
     Description: this.task()?.description,
     'Cron expression': this.task()?.cronExpression,
     'Cron editable': this.task()?.isCronEditable ? 'Yes' : 'No',
+    'Batch size': this.task()?.batchSize,
     'Date created': this.task()?.createdAt.toFormat(this.dateFormat),
     'Created by': this.task()?.createdByFullName,
     'Date modified': this.task()?.lastModifiedAt.toFormat(this.dateFormat),

diff --git a/src/app/admin/models/automated-task/automated-task.interface.ts b/src/app/admin/models/automated-task/automated-task.interface.ts
@@ -8,6 +8,7 @@ export interface AutomatedTaskData {
 
 export interface AutomatedTaskDetailsData extends AutomatedTaskData {
   is_cron_editable: boolean;
+  batch_size: number;
   created_at: string;
   created_by: number;
   last_modified_at: string;

diff --git a/src/app/admin/models/automated-task/automated-task.ts b/src/app/admin/models/automated-task/automated-task.ts
@@ -10,6 +10,7 @@ export type AutomatedTask = {
 
 export type AutomatedTaskDetails = AutomatedTask & {
   isCronEditable: boolean;
+  batchSize: number;
   createdAt: DateTime;
   createdBy: number;
   lastModifiedAt: DateTime;

diff --git a/src/app/admin/services/automated-tasks/automated-tasks.service.ts b/src/app/admin/services/automated-tasks/automated-tasks.service.ts
@@ -51,6 +51,7 @@ export class AutomatedTasksService {
       cronExpression: task.cron_expression,
       isActive: task.is_active,
       isCronEditable: task.is_cron_editable,
+      batchSize: task.batch_size,
       createdAt: DateTime.fromISO(task.created_at),
       createdBy: task.created_by,
       lastModifiedAt: DateTime.fromISO(task.last_modified_at),